1405[FEATURE][CONF] Option to hide BE search box in list mod
Commit message
Review
-
Code review CR +2
- Steffen Kamper +2
- Alexander Stehlik +1
-
Verified V +2
- Steffen Kamper +2
- Alexander Stehlik +1
Issues 1
Files 1
Review log 10
-
Steffen Müller commented on patch set 1 04/03/11, 09:48
(1 inline comment) -
Steffen Müller uploaded patch set 2 04/03/11, 09:48
-
Ernesto Baschny commented on patch set 1 04/03/11, 09:48
Looks good to me, but someone else must approve Looks and sounds nice. If you can, update your commit message to not contain too much information that is already mentioned in the issue tracker.Leave the problem / solution text to the issue tracker. Keep the commit message simple (one line is enough) there is a reference to the issue tracker anyway. -
Steffen Kamper commented on patch set 1 04/03/11, 09:48
(1 inline comment)fetch the change again, make commit -a --amend and change the commit message, push again -
Steffen Kamper commented on patch set 2 V 0 04/03/11, 09:48
by team member; Looks good to me, approved -
Alexander Stehlik commented on patch set 1 04/03/11, 09:48
Verified; Looks good to me, but someone else must approve Works as expected, no problems found. -
Alexander Stehlik commented on patch set 2 04/03/11, 09:48
Verified; Looks good to me, but someone else must approve Since no funcitonal changes you have my vote again. -
Mr. Jenkins commented on patch set 1 04/03/11, 09:48
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/190/ -
Mr. Jenkins commented on patch set 2 04/03/11, 09:48
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/209/ -
Steffen Kamper merged patch set 2 04/03/11, 09:48