Review main Abandoned

14254[BUGFIX] Fixes openID using Google

Ivan Dharma Kartolo CR 0 V 0 Easy +1 −1 updated 06/03/13, 20:49

Commit message

BE User auth fails, if Google is used as OpenID provider.
Cause is that Google gives following URL as OpenID identifier
https://www.google.com/accounts/o8/id?id=xyz
The regex fails on checking the URL.
Regex is fixed.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 09/01/12, 12:44

  2. Wouter Wolters commented on patch set 1 09/01/12, 12:44

    (1 inline comment)
    6.0 should be added here too
  3. Ivan Dharma Kartolo commented on patch set 1 09/01/12, 12:44

    Abandoned please ignore this change set. Reason: Google gives the following URL as Identification URL https://www.google.com/accounts/o8/id?id=xyz OpenID extension searches in be_users table for the matching openid-URL. Since the user doesn't know the xyz param beforehand, there's no way to identificate the user. Google uses https://www.google.com/accounts/o8/id as generic OpenID URL