14258[BUGFIX] LocalDriver can be instantiated without basePath
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
-
Verified V +2
- Steffen Ritter +2
Issues 1
Files 3
Review log 29
Show 4 earlier messages
-
Gerrit wrote 10/12/12, 10:40
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Andreas Wolf uploaded patch set 2 10/12/12, 10:40
-
Andreas Wolf commented on patch set 2 10/12/12, 10:40
The "binary" file LocalDriverTest.php comes from an error with a null byte in the file, introduced during the namespace introduction. This can be fixed by creating a file .git/info/attributes with this content: *.php text diff -
Andreas Wolf uploaded patch set 3 10/12/12, 10:40
-
Andreas Wolf uploaded patch set 4 10/12/12, 10:40
-
Andreas Wolf uploaded patch set 5 10/12/12, 10:40
-
Andreas Wolf commented on patch set 5 10/12/12, 10:40
Rebased patch to current master; already addressed comments by Mario and Oli in the previous patchset. -
Andreas Wolf commented on patch set 6 10/12/12, 10:40
Small fix to make Jenkins happy again :-) -
Andreas Wolf uploaded patch set 6 10/12/12, 10:40
-
Mario Rimann commented on patch set 3 10/12/12, 10:40
I would prefer that you didn't submit thisLocalDriver.php:123What happens if the key "basePath" is set in the $configuration, but contains an empty value? I'd prefer to check for existance AND non-emptiness. -
Oliver Klee commented on patch set 3 10/12/12, 10:40
(1 inline comment)LocalDriver.php:123ReplyWe should cover both cases with unit tests. -
Steffen Ritter commented on patch set 6 10/12/12, 10:40
Looks good to me, but someone else must approve -
Steffen Ritter voted on patch set 6 V 0 10/12/12, 10:40
-
Steffen Ritter commented on patch set 6 V 0 10/12/12, 10:40
by team member; Looks good to me, approved -
Steffen Ritter uploaded patch set 7 10/12/12, 10:40
-
Steffen Ritter uploaded patch set 8 10/12/12, 10:40
-
Steffen Ritter commented on patch set 8 10/12/12, 10:40
Do not submit step by step figuring out the "binary file" thingy and making tests green ;) -
Steffen Ritter uploaded patch set 9 10/12/12, 10:40
-
Steffen Ritter commented on patch set 9 V 0 10/12/12, 10:40
by team member; Looks good to me, approved finally after rebasing, with the original votes - merged -
Mattias Nilsson commented on patch set 6 10/12/12, 10:40
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 10/12/12, 10:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5637/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/12/12, 10:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5638/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/12/12, 10:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5669/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/12/12, 10:40
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6119/ : FAILURE -
Mr. Jenkins commented on patch set 5 10/12/12, 10:40
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6120/ : FAILURE -
Mr. Jenkins commented on patch set 6 10/12/12, 10:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6121/ : SUCCESS -
Mr. Jenkins commented on patch set 7 10/12/12, 10:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6267/ : SUCCESS -
Mr. Jenkins commented on patch set 8 10/12/12, 10:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6269/ : SUCCESS -
Steffen Ritter merged patch set 9 10/12/12, 10:40