Review main Merged

14258[BUGFIX] LocalDriver can be instantiated without basePath

Andreas Wolf CR +2 V +2 Easy +11 −2 updated 06/03/13, 20:49

Commit message

The Local driver of FAL does not check if its configuration contains a
base path, leading to some hard-to-track errors when no path is given.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 3

Review log 29

Show 4 earlier messages
  1. Gerrit wrote 10/12/12, 10:40

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Andreas Wolf uploaded patch set 2 10/12/12, 10:40

  3. Andreas Wolf commented on patch set 2 10/12/12, 10:40

    The "binary" file LocalDriverTest.php comes from an error with a null byte in the file, introduced during the namespace introduction. This can be fixed by creating a file .git/info/attributes with this content: *.php text diff
  4. Andreas Wolf uploaded patch set 3 10/12/12, 10:40

  1. Andreas Wolf uploaded patch set 4 10/12/12, 10:40

  2. Andreas Wolf uploaded patch set 5 10/12/12, 10:40

  3. Andreas Wolf commented on patch set 5 10/12/12, 10:40

    Rebased patch to current master; already addressed comments by Mario and Oli in the previous patchset.
  4. Andreas Wolf commented on patch set 6 10/12/12, 10:40

    Small fix to make Jenkins happy again :-)
  5. Andreas Wolf uploaded patch set 6 10/12/12, 10:40

  6. Mario Rimann commented on patch set 3 10/12/12, 10:40

    I would prefer that you didn't submit this

    LocalDriver.php:123

    What happens if the key "basePath" is set in the $configuration, but contains an empty value? I'd prefer to check for existance AND non-emptiness.
  7. Oliver Klee commented on patch set 3 10/12/12, 10:40

    (1 inline comment)

    LocalDriver.php:123 Reply

    We should cover both cases with unit tests.
  8. Steffen Ritter commented on patch set 6 10/12/12, 10:40

    Looks good to me, but someone else must approve
  9. Steffen Ritter voted on patch set 6 V 0 10/12/12, 10:40

  10. Steffen Ritter commented on patch set 6 V 0 10/12/12, 10:40

    by team member; Looks good to me, approved
  11. Steffen Ritter uploaded patch set 7 10/12/12, 10:40

  12. Steffen Ritter uploaded patch set 8 10/12/12, 10:40

  13. Steffen Ritter commented on patch set 8 10/12/12, 10:40

    Do not submit step by step figuring out the "binary file" thingy and making tests green ;)
  14. Steffen Ritter uploaded patch set 9 10/12/12, 10:40

  15. Steffen Ritter commented on patch set 9 V 0 10/12/12, 10:40

    by team member; Looks good to me, approved finally after rebasing, with the original votes - merged
  16. Mattias Nilsson commented on patch set 6 10/12/12, 10:40

    Verified; Looks good to me, but someone else must approve
  17. Mr. Jenkins commented on patch set 1 10/12/12, 10:40

  18. Mr. Jenkins commented on patch set 2 10/12/12, 10:40

  19. Mr. Jenkins commented on patch set 3 10/12/12, 10:40

  20. Mr. Jenkins commented on patch set 4 10/12/12, 10:40

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6119/ : FAILURE
  21. Mr. Jenkins commented on patch set 5 10/12/12, 10:40

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6120/ : FAILURE
  22. Mr. Jenkins commented on patch set 6 10/12/12, 10:40

  23. Mr. Jenkins commented on patch set 7 10/12/12, 10:40

  24. Mr. Jenkins commented on patch set 8 10/12/12, 10:40

  25. Steffen Ritter merged patch set 9 10/12/12, 10:40