14283[FEATURE] Add stdWrap for _DEFAULT_PI_VARS
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Philipp Gampe +1
-
Verified V +2
- Markus Klein +2
- Philipp Gampe +1
Issues 1
Files 2
Review log 51
Show 26 earlier messages
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
I would prefer that you didn't submit thisDon't use commit-msg to describe what you did between revision 1 and 2 or so but just to describe what the patch itself does.Feature-freeze for 6.0 is over. No new features for older versions. So please change this to 6.1.AbstractPlugin.php:246space between foreach and the bracket. Why GP in the name for these?AbstractPlugin.php:250after $GPKey spaces around the dot used to concat both strings And I assume this stdWrap might be executed two times. Please try with something like: _DEFAULT_PI_VARS.abc = def _DEFAULT_PI_VARS.abc.stdWrap.wrap = XXX|YYY _DEFAULT_PI_VARS.abc.somethingElse = 123 It would strip down the name for "abc." to abc again and rerun the stdWrap-code I assume. But it might be that the abc=def line does not exist (only stdWrap, without a separate value) in which case it would only be executed once. How about simply leaving out the strpos/substr-lines and checking if $GPkey is an array (in which case it will have a dot at the end in correct TypoScript)? Maybe this might be a solution? if (is_array($GPval) && is_array($GPval['stdWrap.']) {{ or so. second is_array could even be an isset imho since if it has a dot (in correct TypoScript) it should be something you can feed into the stdWrap-function imho.AbstractPlugin.php:251can there be a key without a value? Or is this line not needed maybe?AbstractPlugin.php:252Shouldn't you feed it $this->conf['_DEFAULT_PI_VARS.'][$GPkey] (for your current code; the one without the dot at the end) instead of $GPval? $GPval would be the next hierarchy (array containing your 'stdWrap' and maybe something else).AbstractPlugin.php:253hmm - this is how you avoid the double-execution ... I see. But imho it could be avoided in the first place. Other parts of TYPO3 also don't unset 'stdWrap.' when resolving it. Imho this line is "wrong". -
Stefan Busemann commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Ivan Dharma Kartolo uploaded patch set 2 05/27/13, 17:19
Reply
upps. will revert it back again :)Reply
yes you're right... and this is not a bug either :) will be changed.AbstractPlugin.php:246Replyspace will be added. must admit, it's a bad naming. Name will be changed :)AbstractPlugin.php:250Replythe loop has been checked using: abc = def abc.stdwrap { some stdwrap} and xyz.stdWrap { some stdWrap}AbstractPlugin.php:251Replythat's why I add this line. so if there's no value, an empty string will be usedAbstractPlugin.php:252Reply$this->conf['_DEFAULT_PI_VARS.'][$GPkey] could be empty. see the line above, where the GPval is checked. -
Ivan Dharma Kartolo commented on patch set 2 05/27/13, 17:19
(6 inline comments) -
Dmitry Dulepov commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 5 comments 05/27/13, 17:19
I would prefer that you didn't submit this in general fine with me but still found some glitches -
Ivan Dharma Kartolo uploaded patch set 3 05/27/13, 17:19
-
Ivan Dharma Kartolo uploaded patch set 4 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 5 05/27/13, 17:19
(1 inline comment) -
Stefan Neufeind uploaded patch set 6 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 7 05/27/13, 17:19
As suggested by Benjamin rewrote patch to also allow for multilevel values. Added testcases. -
Stefan Neufeind uploaded patch set 7 05/27/13, 17:19
-
Markus Klein uploaded patch set 8 05/27/13, 17:19
-
Markus Klein commented on patch set 8 05/27/13, 17:19
Rebase for 6.2 -
Benni Mack commented on patch set 5 1 comment 05/27/13, 17:19
I would prefer that you didn't submit this Patch works as excepted, BUT the implementation allows only for stdWrap functionality on the first level. the current implementation. plugin.tx_test_pi1._DEFAULT_PI_VARS { abc.def = DEF abc.def.stdWrap { wrap = test | test } } does not work. -
Stefan Busemann commented on patch set 5 05/27/13, 17:19
Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 7 05/27/13, 17:19
Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 8 05/27/13, 17:19
Looks good to me, but someone else must approve -
Ivan Dharma Kartolo uploaded patch set 5 05/27/13, 17:19
-
Ivan Dharma Kartolo commented on patch set 8 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5657/ : FAILURE -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5658/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5685/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6138/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6139/ : SUCCESS
-
Mr. Jenkins commented on patch set 6 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8066/ : FAILURE -
Mr. Jenkins commented on patch set 7 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8067/ : SUCCESS -
Mr. Jenkins commented on patch set 8 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8794/ : SUCCESS -
Markus Klein uploaded patch set 9 06/13/13, 17:45
-
Markus Klein voted on patch set 9 V +2 CR +2 06/13/13, 17:49
-
Wouter Wolters commented on patch set 9 CR -1 06/13/13, 18:25
AbstractPlugin.php:264space after foreach, also for the occurences below -
Markus Klein uploaded patch set 10 06/14/13, 14:04
-
Markus Klein commented on patch set 10 V +2 CR +2 06/14/13, 14:04
Fixed CGL. Hopefully I got all occurrences now. -
Alexander Opitz voted on patch set 10 CR +1 06/14/13, 14:07
-
Wouter Wolters commented on patch set 10 CR +1 06/14/13, 14:21
Thanks for new version. I had no time to update it earlier. -
Oliver Hader commented on patch set 10 CR -1 06/14/13, 14:41
Some remarks on the unit-test... thanks in advance for taking careAbstractPluginTest.php:111Please ensure that this is really any object or mock or TSFE...AbstractPluginTest.php:114Put the two lines above to a usual setUp() method and clean up with tearDown() -
Oliver Hader updated the commit message in patch set 10 06/14/13, 14:44
-
Oliver Hader commented on patch set 11 CR -1 06/14/13, 14:45
Updated commit message, my remarks of patch-set 10 are still valid... -
Markus Klein commented on patch set 10 06/15/13, 12:38
AbstractPluginTest.php:111ReplyI've no idea what you mean, sorry. -
Markus Klein uploaded patch set 12 06/15/13, 12:56
-
Markus Klein voted on patch set 12 V +2 CR +2 06/15/13, 12:58
-
Mr. Jenkins commented on patch set 9 06/17/13, 14:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9060/ : SUCCESS -
Alexander Opitz voted on patch set 12 CR +1 06/17/13, 14:19
-
Philipp Gampe commented on patch set 12 V -1 CR -1 06/20/13, 15:54
The example provided in the commit message does not work. Thus either change the commit message or rework the patch so that it actually works like expected. E.g. you could create a new array based on the return value of stdWrap.this can not work? year.stdWrap.data = date:YAbstractPlugin.php:278you only apply stdWrap to the stdWrap subkey -
Markus Klein commented on patch set 12 06/20/13, 16:06
You're right Philipp. The example is wrong! The unit tests do run fine though. year.data = date:Y Can actually not be possible, 'cause one might want to define a piVar named year.data, hence stdWrap is fine. -
Markus Klein uploaded patch set 13 06/20/13, 16:08
-
Markus Klein commented on patch set 13 V +2 CR +2 06/20/13, 16:09
Updated commit message -
Mr. Jenkins commented on patch set 13 06/20/13, 16:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9099/ : SUCCESS -
Philipp Gampe voted on patch set 13 V +1 CR +1 06/21/13, 11:41
-
Philipp Gampe merged patch set 14 06/21/13, 11:41