Review main Abandoned

14286[BUGFIX] Fixed regex in checkValue_input_Eval

Ivan Dharma Kartolo CR 0 V 0 Easy +33 −2 updated 09/14/14, 00:31

Commit message

false regex is fixed. Escaping special chars

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 17

  1. Benni Mack commented on patch set 1 05/27/13, 17:19

    Can you also provide some unit tests?
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Alexander Opitz commented on patch set 1 09/02/13, 07:52

    What's the state of this issue?
  4. Stefan Froemken uploaded patch set 2 09/05/13, 18:39

  5. Mr. Jenkins commented on patch set 2 09/05/13, 18:40

  6. Stefan Froemken uploaded patch set 3 09/05/13, 19:21

  7. Mr. Jenkins commented on patch set 3 09/05/13, 19:22

  8. Stefan Froemken uploaded patch set 4 09/05/13, 19:43

  9. Mr. Jenkins commented on patch set 4 09/05/13, 19:44

  10. Ivan Dharma Kartolo voted on patch set 4 CR +1 09/05/13, 21:10

  11. Stefan Neufeind commented on patch set 4 V +1 CR +1 09/05/13, 21:47

    Change looks okay/obvious. Test runs fine, though it just tests alphanum_x - but it's a start anyway :-) from which we can later work on in the related areas.
  12. Alexander Opitz voted on patch set 4 CR +1 09/06/13, 06:41

  13. Helmut Hummel commented on patch set 4 V -1 CR -1 09/06/13, 08:15

    Please be more verbose what is actually fixed

    DataHandler.php:2440

    No test case for this change in unit test

    DataHandlerTest.php:168

    Test passes without the change in DataHandler Please provide test cases that show what is actually fixed
  14. Jigal van Hemert commented on patch set 4 V -1 CR -1 09/06/13, 08:32

    See comments. Also the test cases don't cover the functionality completely (as Helmut said).

    DataHandler.php:2440

    No need to escape the '-' because it's the last element in the class. No need to escape the '.' because it has no special meaning in a class. I guess the only change would be to remove the backslash in the regex (which had to be escaped because the backslash itself is the escape character)

    DataHandler.php:2499

    No need to escape the '-' because it's the last element in the class.
  15. Anja Leichsenring commented on patch set 4 09/13/14, 21:09

    something to do here? I checked current master and the change was not applied meanwhile. So what to do?
  16. Helmut Hummel commented on patch set 4 09/14/14, 00:30

    ticket was closed meanwhile, so we can also abandon the change
  17. Helmut Hummel abandoned the change 09/14/14, 00:31

    no change needed apparently