Review main Merged

14301[BUGFIX] Make FAL Folder not found handling more user friendly

Steffen Ritter CR +2 V +2 Normal +41 −27 updated 06/03/13, 20:49

Commit message

If an user moves the folder he currently views in the file
list module, after reload he sees only a red FlashMessage
error because the viewed folder is gone.

As the JavaScript cannot determine what might be the
identifier of the moved folder (after moving) it cannot
redirect there. Thus the file module needs to react more
user friendly in such a situation.

As a solution the module tries parent folders in, too.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Marcel Burkhalter +1

Files 2

Review log 8

  1. Benni Mack commented on patch set 2 V 0 10/03/12, 08:40

    by team member; Looks good to me, approved
  2. Oliver Klee commented on patch set 2 10/03/12, 08:40

    Can we have unit tests for this?
  3. Steffen Ritter uploaded patch set 2 10/03/12, 08:40

  4. Anja Leichsenring commented on patch set 2 10/03/12, 08:40

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 10/03/12, 08:40

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5687/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 10/03/12, 08:40

  7. Marcel Burkhalter commented on patch set 2 V 0 10/03/12, 08:40

    Tested. Looks much better now.
  8. Benni Mack merged patch set 2 10/03/12, 08:40