Review main Merged

14302[BUGFIX] Rootline must not include references to deleted records

Steffen Ritter CR +2 V +2 Easy +1 −0 updated 06/03/13, 20:49

Commit message

The rootline resolval includes deleted records. Deleted
records should never be used in frontend. Add the missing
deleteClause to the request.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Georg Ringer +1
  • Verified V +2
    • Steffen Ritter +2
    • Marcel Burkhalter +1

Files 1

Review log 9

  1. Mario Rimann commented on patch set 1 11/01/12, 10:55

    Looks good to me, but someone else must approve
  2. Stefan Neufeind commented on patch set 1 11/01/12, 10:55

    Looks good to me, but someone else must approve
  3. Oliver Hader commented on patch set 1 11/01/12, 10:55

    (1 inline comment) Post-Code-Review: See my comment on the frontend/backend context - I think it's important to not start over with FE/BE dependencies now we move things to the generic "core" package

    RootlineUtility.php:259

    Hm... this is frontend related only? The question is, what's the scope of RootlineUtility? It's in the "core" package...
  4. Georg Ringer commented on patch set 1 11/01/12, 10:55

    Looks good to me, but someone else must approve
  5. Steffen Ritter commented on patch set 1 V 0 11/01/12, 10:55

    by team member; Looks good to me, approved

    RootlineUtility.php:259 Reply

    it's frontend only - this class is a result extracting a lengthy function out of t3lib_pageSelect to make it cachable, unit-testable and better maintainable. Therefore normally only used in frontend. Anyhow it is only dependend on the "parent pageselect" object, and should work in backend context, if the pageselect ist configured; only thing backend does, is clearing caches - but this happens within the caching framework. If t3lib_pageSelect has been moved to "frontend" package, this should reside there too!
  6. Steffen Ritter merged patch set 1 11/01/12, 10:55

  7. Mr. Jenkins commented on patch set 1 11/01/12, 10:55

  8. Marcel Burkhalter commented on patch set 1 V 0 11/01/12, 10:55

    Tested with a page that contains deleted media records.
  9. Steffen Ritter commented on patch set 1 11/01/12, 10:55

    (1 inline comment)