Review main Merged

14307[BUGFIX] TS Object "FILES" is not able to handle multiple references

Steffen Ritter CR +2 V +2 Easy +4 −2 updated 06/03/13, 20:49

Commit message

The current implementation is not able to deal with more
than one file-reference (hand over as csv).

According to the documentation and to behave like other
options of the FILES object this should be adapted.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Files 1

Review log 9

  1. Mario Rimann commented on patch set 1 09/18/12, 17:15

    Looks good to me, but someone else must approve
  2. Stefan Neufeind commented on patch set 1 09/18/12, 17:15

    Looks good to me, but someone else must approve looks trivial
  3. Oliver Hader commented on patch set 1 09/18/12, 17:15

    Looks good to me, but someone else must approve

    FilesContentObject.php:59

    as - I'll change that
  4. Oliver Hader uploaded patch set 2 09/18/12, 17:15

  5. Mattias Nilsson commented on patch set 1 09/18/12, 17:15

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 09/18/12, 17:15

  7. Marcel Burkhalter commented on patch set 1 V 0 09/18/12, 17:15

    Tested on a page with multiple media files.
  8. Oliver Hader commented on patch set 2 V 0 09/18/12, 17:15

    by team member; Looks good to me, approved
  9. Oliver Hader merged patch set 2 09/18/12, 17:15