Review main Merged

14315[BUGFIX] Editing *_users with saltedpasswords active fails

Steffen Ritter CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Since the namespace changes, the custom form-field-
evaluators for passwords shipped by saltedpasswords are
registered using the namespaced classes.

As the registered class name is used by tceForms to build
an internal JS function, the JS is broken due to the fact
that backslashes are not allowed in JS function names.

This patch reverts back to "classic" classnames as eval
identifier.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Mario Rimann +1
    • Francois Suter +1
  • Verified V +2
    • Steffen Ritter +2
    • Mario Rimann +1
    • Marcel Burkhalter +1
    • Francois Suter +1

Files 2

Review log 7

  1. Francois Suter commented on patch set 1 09/04/12, 08:15

    Verified; Looks good to me, but someone else must approve
  2. Mario Rimann commented on patch set 1 09/04/12, 08:15

    Looks good to me, but someone else must approve
  3. Mario Rimann voted on patch set 1 V 0 09/04/12, 08:15

  4. Mr. Jenkins commented on patch set 1 09/04/12, 08:15

  5. Marcel Burkhalter commented on patch set 1 V 0 09/04/12, 08:15

    Created new BE user, works.
  6. Steffen Ritter commented on patch set 1 V 0 09/04/12, 08:15

    by team member; Looks good to me, approved
  7. Steffen Ritter merged patch set 1 09/04/12, 08:15