14319[BUGFIX] Using listNum in GifBuilder returns empty string
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 6
-
Benni Mack commented on patch set 1 05/27/13, 17:19
Hey michi, your patch is actually having side-effects when unsetting the parameters, as they might be used with other options as well. I accidentally did the same patch here, which solves it "easier to read". In the long-term, the stdWrapping should be done in a separate issue: https://review.typo3.org/#/c/16865/1 How to proceed? -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Why doesn't the !$isStdWrapped[$parameter] work? It looks to me that there is a greater logic flaw in the code and you just pushed a quick and dirty fix? I will need to look deeper into the code to judge that patch :( -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve Ok, the split between the functions break this. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5697/ : SUCCESS -
Michael Stucki commented on patch set 1 07/07/13, 16:17
Hi Benni, thanks for the feedback. I did not check but it very much sounds like your other patch will fix the issue. Therefore, I will abandon this change and mark it as a duplicate. -
Michael Stucki abandoned the change 07/07/13, 16:17