Review main Merged

14363[TASK] CSS StyledContent wraps classes spaceBefore/After twice

Steffen Ritter CR +2 V +2 Easy +5 −5 updated 06/03/13, 20:49

Commit message

Since all top level TypoScript cObject are stdWrap enabled,
setting spaceBefore and spaceAfter fails as the outputtet
classnames are wrapped twice: once within the userFunc and
a second time by the general stdWrap execution.

As the stdWrap ist only meant to act as an configuration
for the userFunc, change the name accordingly, that it is
not processed by the default stdWrap anymore.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Mario Rimann +1
    • Markus Klein +1

Files 2

Review log 11

  1. Mario Rimann commented on patch set 1 V 0 09/22/12, 09:11

    Tested and the spaceBefore / spaceAfter is working again.
  2. Markus Klein commented on patch set 1 V 0 09/22/12, 09:11

    Mean while I added the supposed source of all evil to forge ;-)
  3. Markus Klein commented on patch set 1 09/22/12, 09:11

    Looks good to me, but someone else must approve Is 4.7- affected too?
  4. Markus Klein commented on patch set 1 09/22/12, 09:11

    Ok, but we need documentation for that change too. And the nasty question: Isn't it a feature then? (Although a feature that fixes an even nastier bug)
  5. Markus Klein commented on patch set 1 09/22/12, 09:11

    Sorry, forget my last comment. I mixed things up!
  6. Georg Ringer commented on patch set 1 V 0 09/22/12, 09:11

    by team member; Looks good to me, approved
  7. Steffen Ritter commented on patch set 1 09/22/12, 09:11

    what should be documented? not every option of the CSC stylesheet is documented, is it? And wie do not introduce a feature here, we just rename a parameter because it conflicts with a general "paramter", we could do same for 4.7 - even if it does raise problems there (yet)
  8. Steffen Ritter commented on patch set 1 09/22/12, 09:11

    in 4.7 it works - but I could not identify the changeset which introduced this error.
  9. Mr. Jenkins commented on patch set 1 09/22/12, 09:11

  10. Wouter Wolters commented on patch set 1 09/22/12, 09:11

    Looks good to me, but someone else must approve
  11. Georg Ringer merged patch set 1 09/22/12, 09:11