14363[TASK] CSS StyledContent wraps classes spaceBefore/After twice
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
- Markus Klein +1
-
Verified V +2
- Georg Ringer +2
- Mario Rimann +1
- Markus Klein +1
Files 2
Review log 11
-
Mario Rimann commented on patch set 1 V 0 09/22/12, 09:11
Tested and the spaceBefore / spaceAfter is working again. -
Markus Klein commented on patch set 1 V 0 09/22/12, 09:11
Mean while I added the supposed source of all evil to forge ;-) -
Markus Klein commented on patch set 1 09/22/12, 09:11
Looks good to me, but someone else must approve Is 4.7- affected too? -
Markus Klein commented on patch set 1 09/22/12, 09:11
Ok, but we need documentation for that change too. And the nasty question: Isn't it a feature then? (Although a feature that fixes an even nastier bug) -
Markus Klein commented on patch set 1 09/22/12, 09:11
Sorry, forget my last comment. I mixed things up! -
Georg Ringer commented on patch set 1 V 0 09/22/12, 09:11
by team member; Looks good to me, approved -
Steffen Ritter commented on patch set 1 09/22/12, 09:11
what should be documented? not every option of the CSC stylesheet is documented, is it? And wie do not introduce a feature here, we just rename a parameter because it conflicts with a general "paramter", we could do same for 4.7 - even if it does raise problems there (yet) -
Steffen Ritter commented on patch set 1 09/22/12, 09:11
in 4.7 it works - but I could not identify the changeset which introduced this error. -
Mr. Jenkins commented on patch set 1 09/22/12, 09:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5712/ : SUCCESS -
Wouter Wolters commented on patch set 1 09/22/12, 09:11
Looks good to me, but someone else must approve -
Georg Ringer merged patch set 1 09/22/12, 09:11