Review main Merged

14467[BUGFIX] Warnings in StringUtility

Christian Kuhn CR +2 V +2 Normal +46 −13 updated 06/03/13, 20:49

Commit message

StringUtility::isLastPartOfString does not sanitize the input arguments
enough and throws warnings if calling strlen() for example with arrays.
The patch changes the (new 6.0) method to sanitize the arguments and now
throws Exceptions if they can not be interpreted as string.
The tests are adapted to test for the exception and adds a test with
an object to the data provider.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 3

  1. Mr. Jenkins commented on patch set 1 09/08/12, 20:51

  2. Christian Kuhn commented on patch set 1 V 0 09/08/12, 20:51

    by team member; Looks good to me, approved
  3. Christian Kuhn merged patch set 1 09/08/12, 20:51