Review main Merged

14490[BUGFIX] Switch to List module on root page leads to blank page

Thomas Löffler CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

Reproducable only with admin account. Switch to Page module, go to root
page (id = 0), switch to List module => blank page. Works only on
root page.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 18

  1. Mario Rimann commented on patch set 2 09/18/12, 15:00

    (1 inline comment)
    Is 4.5 not affected or why is it not included here?
  2. Thomas Löffler uploaded patch set 2 09/18/12, 15:00

  3. Thomas Löffler uploaded patch set 3 09/18/12, 15:00

  4. Mattias Nilsson commented on patch set 2 09/18/12, 15:00

    Verified; Looks good to me, but someone else must approve
  5. Ingo Pfennigstorf commented on patch set 1 09/18/12, 15:00

    Maybe it would also be nice to have an @var integer annotation in the id doc comment
  6. Ingo Pfennigstorf commented on patch set 3 09/18/12, 15:00

    I would prefer that you didn't submit this git submodule update ;)
  7. Oliver Hader commented on patch set 5 V 0 09/18/12, 15:00

    by team member; Looks good to me, approved
  8. Oliver Hader uploaded patch set 5 09/18/12, 15:00

  9. Thomas Löffler commented on patch set 4 09/18/12, 15:00

    Verified; Looks good to me, but someone else must approve Thanks for helping out, Ingo.
  10. Philipp Gampe voted on patch set 4 V 0 09/18/12, 15:00

  11. Philipp Gampe commented on patch set 4 09/18/12, 15:00

    Looks good to me, but someone else must approve
  12. Mattias Nilsson commented on patch set 4 09/18/12, 15:00

    Looks good to me, but someone else must approve
  13. Ingo Pfennigstorf uploaded patch set 4 09/18/12, 15:00

  14. Mr. Jenkins commented on patch set 1 09/18/12, 15:00

  15. Mr. Jenkins commented on patch set 2 09/18/12, 15:00

  16. Mr. Jenkins commented on patch set 3 09/18/12, 15:00

  17. Mr. Jenkins commented on patch set 4 09/18/12, 15:00

  18. Oliver Hader merged patch set 5 09/18/12, 15:00