14514[BUGFIX] Uncaught Exception when accessing "Filelist" module in Windows
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Wouter Wolters +1
- Simon Schaufelberger +1
-
Verified V +2
- Oliver Hader +2
- Simon Schaufelberger +1
Files 1
Review log 14
-
Oliver Hader merged patch set 1 09/18/12, 20:07
-
Mr. Jenkins commented on patch set 1 09/18/12, 20:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5757/ : SUCCESS -
Oliver Hader commented on patch set 3 09/18/12, 20:07
Looks good to me, approved -
Oliver Hader commented on patch set 3 09/18/12, 20:07
Can you please test again, I don't have a Windows environment running... -
Oliver Hader commented on patch set 3 V 0 09/18/12, 20:07
by team member Thx for testing -
Oliver Hader uploaded patch set 3 09/18/12, 20:07
-
Simon Schaufelberger commented on patch set 2 09/18/12, 20:07
Verified; Looks good to me, but someone else must approve works very well even though i don't understand why it works in subdirectories -
Simon Schaufelberger commented on patch set 3 09/18/12, 20:07
Verified; Looks good to me, but someone else must approve works very well! -
Mr. Jenkins commented on patch set 2 09/18/12, 20:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5758/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/18/12, 20:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5851/ : SUCCESS -
Wouter Wolters commented on patch set 3 09/18/12, 20:07
Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 2 09/18/12, 20:07
-
Nicole Hummel commented on patch set 2 09/18/12, 20:07
It works with subdirectories because than dirname returns something like 'folder/'. Without any directory set the return is '\' which is converted to '/\/' and throws the exception. -
Nicole Hummel commented on patch set 3 09/18/12, 20:07
Works for me