Review main Merged

14557[TASK] Clean up some ext:belog details and activate tests in travis

Christian Kuhn CR +2 V +2 Hard +138 −162 updated 06/03/13, 20:49

Commit message

Cleans up ext:belog and activates the test suite:
* Fix some annotations
* Move a test that was put to a wrong location
* Minor CGL and readability changes
* Remove namespace compat layer of new 6.0 classes
* Change module registration and viewhelper to namespace

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Helmut Hummel +1

Issues 1

Files 16

Review log 9

  1. Helmut Hummel commented on patch set 1 09/12/12, 21:50

    (1 inline comment)

    LogEntryRepository.php:61

    missing leading backslash
  2. Helmut Hummel uploaded patch set 2 09/12/12, 21:50

  3. Helmut Hummel commented on patch set 2 09/12/12, 21:50

    Verified; Looks good to me, but someone else must approve
  4. Christian Kuhn commented on patch set 2 V 0 09/12/12, 21:50

    by team member; Looks good to me, approved
  5. Mr. Jenkins commented on patch set 1 09/12/12, 21:50

  6. Mr. Jenkins commented on patch set 2 09/12/12, 21:50

  7. Wouter Wolters commented on patch set 1 09/12/12, 21:50

    Verified; Looks good to me, but someone else must approve Check!
  8. Wouter Wolters commented on patch set 2 09/12/12, 21:50

    Verified; Looks good to me, but someone else must approve
  9. Christian Kuhn merged patch set 2 09/12/12, 21:50