1472[BUGFIX] redirectTo field max-value 255 chars
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Björn Pedersen +1
- Christian Kuhn +1
- Stefano Kowalke +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 15
-
Björn Pedersen commented on patch set 1 04/25/11, 14:47
Looks OK for master, but db-changes are not allowed in maintenace releases. -
Björn Pedersen commented on patch set 1 04/25/11, 14:47
Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 2 04/25/11, 14:47
-
Christian Kuhn uploaded patch set 3 04/25/11, 14:47
-
Björn Pedersen commented on patch set 4 04/25/11, 14:47
Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 4 04/25/11, 14:47
-
Christian Kuhn commented on patch set 4 04/25/11, 14:47
Verified; Looks good to me, but someone else must approve 255 seems to be the usual upper limit for such fields, so I changed the patch to use this value. -
Stefano Kowalke commented on patch set 4 04/25/11, 14:47
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/25/11, 14:47
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/227/ -
Mr. Jenkins commented on patch set 2 04/25/11, 14:47
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/318/ : FAILURE -
Mr. Jenkins commented on patch set 3 04/25/11, 14:47
Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/319/ : FAILURE -
Mr. Jenkins commented on patch set 4 04/25/11, 14:47
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/320/ : FAILURE -
Mr. Jenkins commented on patch set 4 04/25/11, 14:47
No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/321/ : SUCCESS -
Susi Moog commented on patch set 4 V 0 04/25/11, 14:47
by team member; Looks good to me, approved -
Susi Moog merged patch set 4 04/25/11, 14:47