Review main Merged

1472[BUGFIX] redirectTo field max-value 255 chars

Markus Bucher CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

It is neccessary to hold more than 120 characters in redirectTo field,
thus changes in ext_table.sql and tbl_cms.php are neccessary. This fix
changes the max-value to 255 chars.

Review

  • Code review CR +2
    • Susi Moog +2
    • Björn Pedersen +1
    • Christian Kuhn +1
    • Stefano Kowalke +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 15

  1. Björn Pedersen commented on patch set 1 04/25/11, 14:47

    Looks OK for master, but db-changes are not allowed in maintenace releases.
  2. Björn Pedersen commented on patch set 1 04/25/11, 14:47

    Looks good to me, but someone else must approve
  3. Christian Kuhn uploaded patch set 2 04/25/11, 14:47

  4. Christian Kuhn uploaded patch set 3 04/25/11, 14:47

  5. Björn Pedersen commented on patch set 4 04/25/11, 14:47

    Looks good to me, but someone else must approve
  6. Christian Kuhn uploaded patch set 4 04/25/11, 14:47

  7. Christian Kuhn commented on patch set 4 04/25/11, 14:47

    Verified; Looks good to me, but someone else must approve 255 seems to be the usual upper limit for such fields, so I changed the patch to use this value.
  8. Stefano Kowalke commented on patch set 4 04/25/11, 14:47

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 04/25/11, 14:47

  10. Mr. Jenkins commented on patch set 2 04/25/11, 14:47

  11. Mr. Jenkins commented on patch set 3 04/25/11, 14:47

  12. Mr. Jenkins commented on patch set 4 04/25/11, 14:47

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/320/ : FAILURE
  13. Mr. Jenkins commented on patch set 4 04/25/11, 14:47

    No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/321/ : SUCCESS
  14. Susi Moog commented on patch set 4 V 0 04/25/11, 14:47

    by team member; Looks good to me, approved
  15. Susi Moog merged patch set 4 04/25/11, 14:47