Review main Merged

1474[BUGFIX] Configuration Tool creates invalid extTables.php file

Markus Klein CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

If extTables.php is empty or not present, this changes takes care of
adding an extra LF after the opening <?php tag.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Georg Ringer +1
    • Jan Loderhose +1
  • Verified V +2
    • Oliver Hader +2
    • Georg Ringer +1
    • Jan Loderhose +1

Issues 1

Files 1

Review log 6

  1. Oliver Hader commented on patch set 1 V 0 04/11/11, 14:36

    by team member; Looks good to me, approved
  2. Georg Ringer commented on patch set 1 04/11/11, 14:36

    Verified; Looks good to me, but someone else must approve
  3. Jan Loderhose commented on patch set 1 04/11/11, 14:36

    Looks good to me, but someone else must approve
  4. Jan Loderhose voted on patch set 1 V 0 04/11/11, 14:36

  5. Mr. Jenkins commented on patch set 1 04/11/11, 14:36

  6. Oliver Hader merged patch set 1 04/11/11, 14:36