Review main Merged

14812[TASK] Database creating fails due to not allowed characters

Nicole Hummel CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

Due to compatibility the CREATE DATABASE statement is used without quotes.
At least for MySQL databases there are limited characters allowed to use
in unquoted database names (0-9,a-z,A-Z$_). At the moment the database
name is parsed with enabled hyphen but this is obviously not allowed. The
parsing has to be changed to meet the MySQL limitation as well.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Issues 1

Files 1

Review log 3

  1. Jigal van Hemert commented on patch set 1 V 0 09/21/12, 20:11

    by team member; Looks good to me, approved No-brainer
  2. Mr. Jenkins commented on patch set 1 09/21/12, 20:11

  3. Jigal van Hemert merged patch set 1 09/21/12, 20:11