Review main Merged

14826[BUGFIX] Make BackendUtility::viewOnClick honor doc

Kasper Ligaard CR +2 V +2 Normal +45 −9 updated 07/27/13, 10:41

Commit message

Make parameter $alternativeUrl work as documented in the docblock
and also as it worked until #22157.
This patch preserves the hook and basically just puts in an
if-statement. Also adding a unit test.

Review

  • Code review CR +2
    • Markus Klein +2
    • Kasper Ligaard +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Files 2

Review log 35

Show 10 earlier messages
  1. Kasper Ligaard commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  2. Kasper Ligaard commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  3. Alexander Opitz uploaded patch set 2 05/27/13, 17:19

  4. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  5. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  6. Morten Pless commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  7. Markus Klein uploaded patch set 3 07/23/13, 09:57

  8. Mr. Jenkins commented on patch set 3 07/23/13, 09:58

  9. Kasper Ligaard voted on patch set 3 CR +1 07/23/13, 10:02

  10. Markus Klein voted on patch set 3 V +1 CR +1 07/23/13, 10:06

  1. Oliver Klee commented on patch set 3 07/23/13, 12:24

    BackendUtility.php:2527

    All in all, there now are 7 levels of indentation. I propose moving the else branch into a separate, well-named method.
  2. Markus Klein commented on patch set 3 07/23/13, 14:43

    @Oliver: Feel free to push a new version
  3. Oliver Klee uploaded patch set 4 07/23/13, 16:31

  4. Mr. Jenkins commented on patch set 4 07/23/13, 16:32

  5. Oliver Klee commented on patch set 4 07/23/13, 16:33

    Just refactored the else branch to a separate method. This code is not tested.
  6. Kasper Ligaard uploaded patch set 5 07/23/13, 18:59

  7. Mr. Jenkins commented on patch set 5 07/23/13, 19:00

  8. Kasper Ligaard commented on patch set 5 07/23/13, 19:01

    I like Olivers patch set. I have expanded his patch with a unit test in BackendUtilityTest.php.
  9. Wouter Wolters commented on patch set 5 07/23/13, 19:19

    Thanks Kasper for the Unit-test, I have one small nitpick. I would have pushed myself a new patchset but am not able to do it right now.

    BackendUtilityTest.php:685

    null -> NULL
  10. Kasper Ligaard commented on patch set 5 07/23/13, 21:26

    @wouter: If it is simple, then maybe you could describe it in here and then I would incorporate you ideas and upload a new patch set for review..?
  11. Markus Klein commented on patch set 5 07/24/13, 08:59

    He made a comment in the file.
  12. Markus Klein uploaded patch set 6 07/24/13, 09:09

  13. Mr. Jenkins commented on patch set 6 07/24/13, 09:10

  14. Markus Klein voted on patch set 6 CR +1 07/24/13, 09:11

  15. Kasper Ligaard commented on patch set 6 V +1 CR +1 07/24/13, 09:16

    @markus: Thanks, I didn't get that. I have tested and (unsurprisingly) it still works :-)
  16. Kasper Ligaard commented on patch set 6 07/26/13, 09:34

    @wouter: With the change in patch set 6, I think this is ready to commit. What do you think?
  17. Wouter Wolters commented on patch set 6 V +1 CR +1 07/26/13, 12:26

    Only verified the Unit-test. I would not backport this to 4.7, only security patches for 4.7 now.
  18. Kasper Ligaard commented on patch set 6 V 0 CR 0 07/26/13, 13:59

    @wouter: Should I remove 4.7 and 4.5 from the commit message and upload a new patch set?
  19. Wouter Wolters updated the commit message in patch set 6 07/26/13, 14:05

  20. Wouter Wolters voted on patch set 7 V +1 CR +1 07/26/13, 14:05

  21. Mr. Jenkins commented on patch set 7 07/26/13, 14:06

  22. Kasper Ligaard voted on patch set 7 CR +1 07/26/13, 16:37

  23. Markus Klein voted on patch set 7 V +2 CR +2 07/27/13, 10:41

  24. Markus Klein merged patch set 8 07/27/13, 10:41

  25. Markus Klein commented on patch set 8 07/27/13, 10:41

    Cherry Picked This patchset was cherry picked to change: I7d67af438b0a0af51ca7662b3f8286aeec827c77