Review main Merged

14836[TASK] Introduce base class for PHPUnit tests

Markus Klein CR +2 V +2 Hard +549 −399 updated 06/03/13, 20:49

Commit message

Previously all core unit tests extended from the
Tx_PhpUnit_TestCase. This turned out to be problematic
because the core tests relied on the behaviour of that
class and we could not easily change behaviour centrally
for the core tests.
Because of that, we introduced several own base test classes
which added functionality for specific test cases.

With introducing a new base test case class which is
extended by all core test, we can consolidate helper
functions and specific wanted behaviour like blacklisting
TYPO3_DB globals for all tests.

Additionally all tests will benefit from
future enhancements in the base class.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +2
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +2

Issues 1

Files 119

Show 99 more files

Review log 31

Show 6 earlier messages
  1. Gerrit wrote 09/22/12, 21:33

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Gerrit wrote 09/22/12, 21:33

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  3. Markus Klein uploaded patch set 2 09/22/12, 21:33

  4. Markus Klein uploaded patch set 3 09/22/12, 21:33

  5. Helmut Hummel uploaded patch set 4 09/22/12, 21:33

  6. Helmut Hummel uploaded patch set 5 09/22/12, 21:33

  1. Helmut Hummel uploaded patch set 6 09/22/12, 21:33

  2. Helmut Hummel uploaded patch set 7 09/22/12, 21:33

  3. Christian Kuhn commented on patch set 3 09/22/12, 21:33

    I would prefer that you didn't submit this Very good idea, love it! will review and finish!
  4. Helmut Hummel uploaded patch set 9 09/22/12, 21:33

  5. Helmut Hummel commented on patch set 9 09/22/12, 21:33

    Verified; Looks good to me, but someone else must approve
  6. Helmut Hummel uploaded patch set 10 09/22/12, 21:33

  7. Helmut Hummel commented on patch set 10 09/22/12, 21:33

    Verified; Looks good to me, but someone else must approve
  8. Helmut Hummel uploaded patch set 11 09/22/12, 21:33

  9. Helmut Hummel commented on patch set 11 V 0 09/22/12, 21:33

    by team member; Looks good to me, approved
  10. Christian Kuhn uploaded patch set 8 09/22/12, 21:33

  11. Christian Kuhn commented on patch set 10 V 0 09/22/12, 21:33

    by team member; Looks good to me, approved
  12. Georg Ringer commented on patch set 10 V 0 09/22/12, 21:33

    by team member; Looks good to me, approved
  13. Mr. Jenkins commented on patch set 1 09/22/12, 21:33

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5901/ : FAILURE
  14. Mr. Jenkins commented on patch set 2 09/22/12, 21:33

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5906/ : FAILURE
  15. Mr. Jenkins commented on patch set 3 09/22/12, 21:33

  16. Mr. Jenkins commented on patch set 4 09/22/12, 21:33

  17. Mr. Jenkins commented on patch set 5 09/22/12, 21:33

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6002/ : FAILURE
  18. Mr. Jenkins commented on patch set 6 09/22/12, 21:33

  19. Mr. Jenkins commented on patch set 7 09/22/12, 21:33

  20. Mr. Jenkins commented on patch set 7 09/22/12, 21:33

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6012/ : FAILURE
  21. Mr. Jenkins commented on patch set 8 09/22/12, 21:33

  22. Mr. Jenkins commented on patch set 9 09/22/12, 21:33

  23. Mr. Jenkins commented on patch set 10 09/22/12, 21:33

  24. Christian Kuhn commented on patch set 11 V 0 09/22/12, 21:33

    by team member; Looks good to me, approved
  25. Christian Kuhn merged patch set 11 09/22/12, 21:33