14850[TASK] Fix CGL violations against NonExecutableCode
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 4
Review log 6
-
Christian Kuhn commented on patch set 1 V 0 09/21/12, 20:06
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 1 09/21/12, 20:06
Looks good to me, but someone else must approveImportExport.php:1825are your sure that this is side effect free to include the death code now? -
Philipp Gampe commented on patch set 1 V 0 09/21/12, 20:06
I did not test the actual code, I just check that this applies clean on current master. -
Mr. Jenkins commented on patch set 1 09/21/12, 20:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5907/ : SUCCESS -
Wouter Wolters commented on patch set 1 09/21/12, 20:06
(1 inline comment)ImportExport.php:1825ReplyHmm, good point.The case was below the default. I'm 100% sure if it get executed or not.. after the default there were 2 break statements. My guess is that this will work but the warning was about the second break statement. -
Christian Kuhn merged patch set 1 09/21/12, 20:06