Review main Merged

14948[TASK] add leading backslashes to Date*

Anja Leichsenring CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

for some cases the leading backslash is missing for PHP standard
classes. This patch adds those backslashes to Date*.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 12

  1. Christian Kuhn commented on patch set 2 09/22/12, 21:49

    (4 inline comments)

    CookieJar.php:113

    No changes in this class

    adodb-time.inc.php:249

    no changes in contrib files.

    adodb-mssqlnative.inc.php:436

    no changes in contrib files

    Repository.php:76

    this change is ok!
  2. Christian Kuhn commented on patch set 2 09/22/12, 21:49

    I would prefer that you didn't submit this no changes in contrib packages like adodb!
  3. Philipp Gampe uploaded patch set 2 09/22/12, 21:49

  4. Philipp Gampe commented on patch set 2 09/22/12, 21:49

    Verified; Looks good to me, but someone else must approve I hope the HTTP request stuff does not break but +1 from my side until now.
  5. Philipp Gampe commented on patch set 2 09/22/12, 21:49

    just rebased
  6. Philipp Gampe commented on patch set 3 09/22/12, 21:49

    Verified; Looks good to me, but someone else must approve no changes in external projects
  7. Philipp Gampe uploaded patch set 3 09/22/12, 21:49

  8. Mr. Jenkins commented on patch set 1 09/22/12, 21:49

  9. Mr. Jenkins commented on patch set 2 09/22/12, 21:49

  10. Mr. Jenkins commented on patch set 3 09/22/12, 21:49

  11. Christian Kuhn commented on patch set 3 V 0 09/22/12, 21:49

    by team member; Looks good to me, approved
  12. Christian Kuhn merged patch set 3 09/22/12, 21:49