14948[TASK] add leading backslashes to Date*
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 12
-
Christian Kuhn commented on patch set 2 09/22/12, 21:49
(4 inline comments)CookieJar.php:113No changes in this classadodb-time.inc.php:249no changes in contrib files.adodb-mssqlnative.inc.php:436no changes in contrib filesRepository.php:76this change is ok! -
Christian Kuhn commented on patch set 2 09/22/12, 21:49
I would prefer that you didn't submit this no changes in contrib packages like adodb! -
Philipp Gampe uploaded patch set 2 09/22/12, 21:49
-
Philipp Gampe commented on patch set 2 09/22/12, 21:49
Verified; Looks good to me, but someone else must approve I hope the HTTP request stuff does not break but +1 from my side until now. -
Philipp Gampe commented on patch set 2 09/22/12, 21:49
just rebased -
Philipp Gampe commented on patch set 3 09/22/12, 21:49
Verified; Looks good to me, but someone else must approve no changes in external projects -
Philipp Gampe uploaded patch set 3 09/22/12, 21:49
-
Mr. Jenkins commented on patch set 1 09/22/12, 21:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6027/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/22/12, 21:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6032/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/22/12, 21:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6035/ : SUCCESS -
Christian Kuhn commented on patch set 3 V 0 09/22/12, 21:49
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 09/22/12, 21:49