Review main Abandoned

1504Fix bug 25834 - initialize default output to false for sql_fetch_assoc() and sql-fetch_row() (DBAL)

Gabe Blair CR 0 V 0 Easy +3 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Xavier Perseguers commented on patch set 1 04/07/11, 22:03

    (4 inline comments) Thanks for your patch. Please have a look at my comments when you recreate your patch for DBAL repository. Using the "Resolves: #..." format will automatically "link" the review to the bug tracker entry... Thanks!
    [BUGFIX] sql_fetch_assoc() and sql_fetch_row() should default to FALSE Initialize default output to FALSE for sql_fetch_assoc() and sql_fetch_row().
    Resolves: #25834

    class.ux_t3lib_db.php:2218

    Please use "FALSE" instead of "false"

    class.ux_t3lib_db.php:2281

    $output = FALSE;
  2. Mr. Jenkins commented on patch set 1 04/07/11, 22:03

  3. Gabe Blair commented on patch set 1 04/07/11, 22:03

    Abandoned Dropping this patch to do it in the DBAL repository