Review main Merged

15068[TASK] Add leading backslashes to InvalidArgumentException

Anja Leichsenring CR +2 V +2 Normal +65 −72 updated 06/03/13, 20:49

Commit message

for some cases the leading backslash is missing for PHP standard
classes. This patch adds those backslashes to InvalidArgumentException.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 21

Review log 8

  1. Anja Leichsenring uploaded patch set 2 09/26/12, 06:31

  2. Helmut Hummel commented on patch set 3 V 0 09/26/12, 06:31

    by team member; Looks good to me, approved
  3. Anja Leichsenring uploaded patch set 3 09/26/12, 06:31

  4. Mr. Jenkins commented on patch set 1 09/26/12, 06:31

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6063/ : FAILURE
  5. Mr. Jenkins commented on patch set 2 09/26/12, 06:31

  6. Mr. Jenkins commented on patch set 3 09/26/12, 06:31

  7. Wouter Wolters commented on patch set 3 09/26/12, 06:31

    Looks good to me, but someone else must approve
  8. Helmut Hummel merged patch set 3 09/26/12, 06:31