1507[FEATURE] Monitor peak memory usage
Commit message
Review
-
Code review CR -1
- Jigal van Hemert +2
- Stefan Neufeind +1
- Thorsten Kahler -1
- Susi Moog +1
- Philipp Gampe +1
-
Verified V +2
- Thorsten Kahler +2
- Stefan Neufeind +1
- Susi Moog +1
- Philipp Gampe +1
Issues 1
Files 5
Review log 17
-
Steffen Gebert commented on patch set 1 07/31/11, 20:40
(5 inline comments) I like the idea.. (although it's a again a thing which slows down rendering times a bit).class.t3lib_utility_monitor.php:44if ($memoryLimit > 0) ?class.t3lib_utility_monitor.php:49What about $GLOBALS['EXEC_TIME']? (btw. time() should be preferred over mktime() according to PHP doc)class.t3lib_utility_monitor.php:53Wouldn't the registry be a better place to store this information?locallang.xml:44What about: A critical memory usage of %2$s (%1$s of allowed %3$s) was observed during a request to %5$s on %4$slocallang.xml:45"click to blabla".. umm.. it's obviously a link - so why not "clear counter"? -
Jigal van Hemert commented on patch set 1 07/31/11, 20:40
(4 inline comments)class.t3lib_utility_monitor.php:44Replychanged in patch set 2, != 0 is only necessary to prevent division by zero.class.t3lib_utility_monitor.php:49ReplyDoneclass.t3lib_utility_monitor.php:53ReplyDonelocallang.xml:45ReplyDone -
Thorsten Kahler commented on patch set 2 V 0 1 comment 07/31/11, 20:40
by team member; I would prefer that you didn't submit this This version causes a (minor) performance regression. An option to disable the memory check should be added. -
Stefan Neufeind commented on patch set 2 07/31/11, 20:40
Jigal, could you negotiate a solution maybe? -
Stefan Neufeind commented on patch set 2 07/31/11, 20:40
Looks good to me, but someone else must approve -
Stefan Neufeind voted on patch set 2 V 0 1 comment 07/31/11, 20:40
-
Susi Moog commented on patch set 2 07/31/11, 20:40
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 2 07/31/11, 20:40
If you have a solution, be my guest. It's a tiny check for a situation which usually requires a lot of debugging effort ("which request causes a blank page because PHP runs out of memory sometimes?") Compared to the numerous time tracker calls for FE and the recently re-introduced hook for each item in the page tree this check is very cheap. Adding yet another configuration option is certainly not desirable and will also add extra processing. -
Jigal van Hemert commented on patch set 2 07/31/11, 20:40
(1 inline comment) -
Jigal van Hemert uploaded patch set 2 07/31/11, 20:40
-
Philipp Gampe commented on patch set 2 07/31/11, 20:40
Fails For me the message in reports module only hows the percentage :(class.tx_reports_reports_status_systemstatus.php:150This line returns an empty result for me ???class.tx_reports_reports_status_systemstatus.php:150ReplyNo, I use master "as-is". However it does not work if I change another label either :( -
Philipp Gampe commented on patch set 2 07/31/11, 20:40
(1 inline comment) see command, however this might be my installation. -
Philipp Gampe commented on patch set 2 07/31/11, 20:40
Verified; Looks good to me, but someone else must approve Works for me now. -
Mr. Jenkins commented on patch set 1 07/31/11, 20:40
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/232/ -
Mr. Jenkins commented on patch set 2 07/31/11, 20:40
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/248/ -
Jigal van Hemert commented on patch set 2 07/31/11, 20:40
Looks good to me, approved Enough votes... -
Jigal van Hemert merged patch set 2 07/31/11, 20:40