Review main Merged

1507[FEATURE] Monitor peak memory usage

Jigal van Hemert CR -1 V +2 Normal +126 −0 updated 06/03/13, 20:49

Commit message

Monitor the peak memory usage during page generation and report if
it exceeds 90% of the memory limit.

Review

  • Code review CR -1
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Thorsten Kahler -1
    • Susi Moog +1
    • Philipp Gampe +1
  • Verified V +2
    • Thorsten Kahler +2
    • Stefan Neufeind +1
    • Susi Moog +1
    • Philipp Gampe +1

Issues 1

Files 5

Review log 17

  1. Steffen Gebert commented on patch set 1 07/31/11, 20:40

    (5 inline comments) I like the idea.. (although it's a again a thing which slows down rendering times a bit).

    class.t3lib_utility_monitor.php:44

    if ($memoryLimit > 0) ?

    class.t3lib_utility_monitor.php:49

    What about $GLOBALS['EXEC_TIME']? (btw. time() should be preferred over mktime() according to PHP doc)

    class.t3lib_utility_monitor.php:53

    Wouldn't the registry be a better place to store this information?

    locallang.xml:44

    What about: A critical memory usage of %2$s (%1$s of allowed %3$s) was observed during a request to %5$s on %4$s

    locallang.xml:45

    "click to blabla".. umm.. it's obviously a link - so why not "clear counter"?
  2. Jigal van Hemert commented on patch set 1 07/31/11, 20:40

    (4 inline comments)

    class.t3lib_utility_monitor.php:44 Reply

    changed in patch set 2, != 0 is only necessary to prevent division by zero.

    class.t3lib_utility_monitor.php:49 Reply

    Done

    class.t3lib_utility_monitor.php:53 Reply

    Done

    locallang.xml:45 Reply

    Done
  3. Thorsten Kahler commented on patch set 2 V 0 1 comment 07/31/11, 20:40

    by team member; I would prefer that you didn't submit this This version causes a (minor) performance regression. An option to disable the memory check should be added.
  4. Stefan Neufeind commented on patch set 2 07/31/11, 20:40

    Jigal, could you negotiate a solution maybe?
  5. Stefan Neufeind commented on patch set 2 07/31/11, 20:40

    Looks good to me, but someone else must approve
  6. Stefan Neufeind voted on patch set 2 V 0 1 comment 07/31/11, 20:40

  7. Susi Moog commented on patch set 2 07/31/11, 20:40

    Verified; Looks good to me, but someone else must approve
  8. Jigal van Hemert commented on patch set 2 07/31/11, 20:40

    If you have a solution, be my guest. It's a tiny check for a situation which usually requires a lot of debugging effort ("which request causes a blank page because PHP runs out of memory sometimes?") Compared to the numerous time tracker calls for FE and the recently re-introduced hook for each item in the page tree this check is very cheap. Adding yet another configuration option is certainly not desirable and will also add extra processing.
  9. Jigal van Hemert commented on patch set 2 07/31/11, 20:40

    (1 inline comment)
  10. Jigal van Hemert uploaded patch set 2 07/31/11, 20:40

  11. Philipp Gampe commented on patch set 2 07/31/11, 20:40

    Fails For me the message in reports module only hows the percentage :(

    class.tx_reports_reports_status_systemstatus.php:150

    This line returns an empty result for me ???

    class.tx_reports_reports_status_systemstatus.php:150 Reply

    No, I use master "as-is". However it does not work if I change another label either :(
  12. Philipp Gampe commented on patch set 2 07/31/11, 20:40

    (1 inline comment) see command, however this might be my installation.
  13. Philipp Gampe commented on patch set 2 07/31/11, 20:40

    Verified; Looks good to me, but someone else must approve Works for me now.
  14. Mr. Jenkins commented on patch set 1 07/31/11, 20:40

  15. Mr. Jenkins commented on patch set 2 07/31/11, 20:40

  16. Jigal van Hemert commented on patch set 2 07/31/11, 20:40

    Looks good to me, approved Enough votes...
  17. Jigal van Hemert merged patch set 2 07/31/11, 20:40