Review main Merged

15118[BUGFIX] Shared defaults for CE wizard using TCAdefaults

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 07/05/13, 21:53

Commit message

The page TSconfig settings for the New Content Element wizard have
a higher priority than the user TSconfig TCAdefaults. Settings which
are not different for each CE type should be set in TCAdefaults. If
they are set in the tt_content_defVals the values will be different
if the editor selected the right CE type directly than if the editor
switched CE type.

Review

  • Code review CR +2
    • Philipp Gampe +2
  • Verified V +2
    • Philipp Gampe +2

Files 1

Review log 26

Show 1 earlier messages
  1. Stefan Neufeind commented on patch set 1 1 comment 05/27/13, 17:19

    Looks good to me, but someone else must approve Don't know how I'd test it but seems to make sense by reading comment and code.
  1. Georg Ringer commented on patch set 1 05/27/13, 17:19

    (1 inline comment)
  2. Jigal van Hemert commented on patch set 1 05/27/13, 17:19

    (1 inline comment)
  3. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve

    ext_localconf.php:31

    same here?
  4. Philipp Gampe commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Rebased to master. To test: Logout and Login to apply settings Create a Text CE Change this to Images See appearance > number of columns is set to 2 after the patch and 1 before.
  5. Philipp Gampe uploaded patch set 2 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  8. Philipp Gampe commented on patch set 3 1 comment 05/27/13, 17:19

    Verified; I would prefer that you didn't submit this
  9. Stefan Neufeind commented on patch set 4 05/27/13, 17:19

    Looks good to me, but someone else must approve almost nobrainer / quite obvious given the description
  10. Philipp Gampe uploaded patch set 4 05/27/13, 17:19

  11. Philipp Gampe commented on patch set 4 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve BUG -> BUGFIX
  12. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  13. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  14. Wouter Wolters uploaded patch set 3 05/27/13, 17:19

  15. Wouter Wolters commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve Only updated commit message
  16. Wouter Wolters uploaded patch set 5 05/28/13, 20:09

  17. Mr. Jenkins commented on patch set 5 05/28/13, 20:10

  18. Susi Moog commented on patch set 5 06/03/13, 20:28

    Looks good to me, but someone else must approve
  19. Jo Hasenau voted on patch set 5 V +1 CR +1 07/04/13, 16:22

  20. Georg Ringer commented on patch set 5 V +1 CR +1 07/04/13, 18:06

    Usually this is BUGFIX ;)
  21. Philipp Gampe updated the commit message in patch set 5 07/05/13, 21:52

    BUGFIX
  22. Philipp Gampe commented on patch set 6 V +2 CR +2 07/05/13, 21:53

    removed 4.x from releases list
  23. Philipp Gampe merged patch set 7 07/05/13, 21:53

  24. Mr. Jenkins commented on patch set 6 07/05/13, 21:53

  25. Philipp Gampe commented on patch set 7 07/05/13, 21:53

    Cherry Picked This patchset was cherry picked to change: I8b84b3059b17f88a3d674b6faae889844cae9c67