15118[BUGFIX] Shared defaults for CE wizard using TCAdefaults
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
-
Verified V +2
- Philipp Gampe +2
Files 1
Review log 26
Show 1 earlier messages
-
Stefan Neufeind commented on patch set 1 1 comment 05/27/13, 17:19
Looks good to me, but someone else must approve Don't know how I'd test it but seems to make sense by reading comment and code.
-
Georg Ringer commented on patch set 1 05/27/13, 17:19
(1 inline comment) -
Jigal van Hemert commented on patch set 1 05/27/13, 17:19
(1 inline comment) -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approveext_localconf.php:31same here? -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Rebased to master. To test: Logout and Login to apply settings Create a Text CE Change this to Images See appearance > number of columns is set to 2 after the patch and 1 before. -
Philipp Gampe uploaded patch set 2 05/27/13, 17:19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6077/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7371/ : SUCCESS -
Philipp Gampe commented on patch set 3 1 comment 05/27/13, 17:19
Verified; I would prefer that you didn't submit this -
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve almost nobrainer / quite obvious given the description -
Philipp Gampe uploaded patch set 4 05/27/13, 17:19
-
Philipp Gampe commented on patch set 4 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve BUG -> BUGFIX -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7574/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7900/ : SUCCESS -
Wouter Wolters uploaded patch set 3 05/27/13, 17:19
-
Wouter Wolters commented on patch set 3 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Only updated commit message -
Wouter Wolters uploaded patch set 5 05/28/13, 20:09
-
Mr. Jenkins commented on patch set 5 05/28/13, 20:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8927/ : SUCCESS -
Susi Moog commented on patch set 5 06/03/13, 20:28
Looks good to me, but someone else must approve -
Jo Hasenau voted on patch set 5 V +1 CR +1 07/04/13, 16:22
-
Georg Ringer commented on patch set 5 V +1 CR +1 07/04/13, 18:06
Usually this is BUGFIX ;) -
Philipp Gampe updated the commit message in patch set 5 07/05/13, 21:52
BUGFIX -
Philipp Gampe commented on patch set 6 V +2 CR +2 07/05/13, 21:53
removed 4.x from releases list -
Philipp Gampe merged patch set 7 07/05/13, 21:53
-
Mr. Jenkins commented on patch set 6 07/05/13, 21:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9434/ : SUCCESS -
Philipp Gampe commented on patch set 7 07/05/13, 21:53
Cherry Picked This patchset was cherry picked to change: I8b84b3059b17f88a3d674b6faae889844cae9c67