15167[TASK] GGL violation "Tabs must be used to indent lines"
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 4
Review log 11
-
Dmitry Dulepov commented on patch set 2 10/28/12, 16:01
(4 inline comments) I guess we need a better commit message here because none of changes deals with space-to-tab.BaseTestCase.php:4Not a space-to-tab change.FunctionalTestCase.php:4Not a space-to-tab change.UnitTestCase.php:4Not a space-to-tab change.TceformsUpdateWizard.php:119This is not a change of spaces to tabs. -
Oliver Klee commented on patch set 2 10/28/12, 16:01
Looks good to me, but someone else must approve -
mostwanted commented on patch set 2 10/28/12, 16:01
please see the details (detail button) on https://ci.typo3.org/view/TYPO3/view/Core/job/typo3-v4-core-nightly/670/checkstyleResult/category.81291599/ - i used the wording from "Tabs must be used to indent lines; spaces are not allowed" messages. i think the commit message is ok, because the patch removes spaces where you would have to use tabs (if you wanted to intend anyway). but please feel free to change the title if it helps. -
mostwanted uploaded patch set 2 10/28/12, 16:01
-
Philipp Gampe commented on patch set 2 10/28/12, 16:01
Looks good to me, but someone else must approve -
Philipp Gampe voted on patch set 2 V 0 10/28/12, 16:01
-
Mr. Jenkins commented on patch set 1 10/28/12, 16:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6097/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/28/12, 16:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6099/ : SUCCESS -
Wouter Wolters commented on patch set 2 10/28/12, 16:01
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 V 0 10/28/12, 16:01
by team member; Looks good to me, approved I'm fine with the commit message and will merge this now. -
Christian Kuhn merged patch set 2 10/28/12, 16:01