15172[TASK] CGL violations "LineEndingsInvalidEOLChar"
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
- Oliver Klee +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Dmitry Dulepov +2
- Philipp Gampe +1
Issues 1
Files 4
Review log 18
-
mostwanted uploaded patch set 2 10/03/12, 10:37
-
mostwanted uploaded patch set 3 10/03/12, 10:37
-
mostwanted commented on patch set 3 10/03/12, 10:37
have i? i am not sure, are you? -
mostwanted uploaded patch set 4 10/03/12, 10:37
-
Philipp Gampe commented on patch set 3 10/03/12, 10:37
I would prefer that you didn't submit this I will push an updateTreeElement.php:175???? this does not look related ... did I introduced this? -
Philipp Gampe commented on patch set 3 10/03/12, 10:37
No score ok, you fixed it already :) -
Philipp Gampe commented on patch set 3 10/03/12, 10:37
I was refering to patchset 2 :D but I will fix patchset 3 now ... just a second please -
Dmitry Dulepov commented on patch set 5 V 0 10/03/12, 10:37
by team member; Looks good to me, approved -
Oliver Klee commented on patch set 5 10/03/12, 10:37
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 10/03/12, 10:37
Verified; Looks good to me, but someone else must approve I ran a $ find typo3/ -type f -name "*.php" |xargs dos2unix t3lib is clean already ... -
Philipp Gampe commented on patch set 5 10/03/12, 10:37
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 1 comment 10/03/12, 10:37
I would prefer that you didn't submit this -
Philipp Gampe uploaded patch set 5 10/03/12, 10:37
-
Mr. Jenkins commented on patch set 2 10/03/12, 10:37
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6101/ : FAILURE -
Mr. Jenkins commented on patch set 3 10/03/12, 10:37
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6102/ : FAILURE -
Mr. Jenkins commented on patch set 5 10/03/12, 10:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6104/ : SUCCESS -
Wouter Wolters commented on patch set 5 10/03/12, 10:37
Looks good to me, but someone else must approve -
Dmitry Dulepov merged patch set 5 10/03/12, 10:37