15198[TASK] CGL violations "AssignmentArithmeticAndComparisonSpace"
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 37
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −1
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+9 −9
- typo3/sysext/backend/Classes/Form/Element/SuggestDefaultReceiver.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SuggestElement.php+1 −1
- typo3/sysext/backend/Classes/Form/DataPreprocessor.php+1 −1
- typo3/sysext/backend/Classes/Form/FormEngine.php+6 −6
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+3 −3
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+5 −5
- typo3/sysext/backend/Classes/User/ExtDirect/BackendUserSettingsDataProvider.php+4 −4
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+8 −8
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+2 −2
- typo3/sysext/core/Classes/Database/QueryGenerator.php+10 −10
- typo3/sysext/core/Classes/Database/SqlParser.php+5 −5
- typo3/sysext/core/Classes/Extension/ExtensionManager.php+2 −2
- typo3/sysext/core/Classes/Page/PageRenderer.php+4 −4
- typo3/sysext/core/Classes/Resource/Driver/DriverRegistry.php+2 −2
Show 17 more files
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/ClientUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+4 −4
- typo3/sysext/extensionmanager/Classes/Utility/Parser/XmlParserFactory.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/ImageMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Hook/MysqlFulltextIndexHook.php+1 −1
- typo3/sysext/lowlevel/Classes/CleanFlexformCommand.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+2 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+1 −1
- typo3/sysext/rsaauth/Classes/Hook/UserSetupHook.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaApi.php+4 −4
- typo3/sysext/t3editor/Classes/T3Editor.php+1 −1
- typo3/sysext/tstemplate_info/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+2 −2
Review log 13
-
mostwanted commented on patch set 1 10/28/12, 18:55
I would prefer that you didn't submit this will push new patch in a minute. -
mostwanted uploaded patch set 2 10/28/12, 18:55
-
mostwanted uploaded patch set 3 10/28/12, 18:55
-
mostwanted uploaded patch set 4 10/28/12, 18:55
-
mostwanted uploaded patch set 5 10/28/12, 18:55
-
Mr. Jenkins commented on patch set 1 10/28/12, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6107/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/28/12, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6108/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/28/12, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6109/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/28/12, 18:55
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6439/ : FAILURE -
Mr. Jenkins commented on patch set 5 10/28/12, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6440/ : SUCCESS -
Wouter Wolters commented on patch set 3 10/28/12, 18:55
I would prefer that you didn't submit this Roland, openid is a third party library and can be left out for the CGL. Can you repush this patch wihtout openid? -
Christian Kuhn commented on patch set 5 V 0 10/28/12, 18:55
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 5 10/28/12, 18:55