Review main Merged

15198[TASK] CGL violations "AssignmentArithmeticAndComparisonSpace"

mostwanted CR +2 V +2 Normal +98 −98 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 37

Show 17 more files

Review log 13

  1. mostwanted commented on patch set 1 10/28/12, 18:55

    I would prefer that you didn't submit this will push new patch in a minute.
  2. mostwanted uploaded patch set 2 10/28/12, 18:55

  3. mostwanted uploaded patch set 3 10/28/12, 18:55

  4. mostwanted uploaded patch set 4 10/28/12, 18:55

  5. mostwanted uploaded patch set 5 10/28/12, 18:55

  6. Mr. Jenkins commented on patch set 1 10/28/12, 18:55

  7. Mr. Jenkins commented on patch set 2 10/28/12, 18:55

  8. Mr. Jenkins commented on patch set 3 10/28/12, 18:55

  9. Mr. Jenkins commented on patch set 4 10/28/12, 18:55

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6439/ : FAILURE
  10. Mr. Jenkins commented on patch set 5 10/28/12, 18:55

  11. Wouter Wolters commented on patch set 3 10/28/12, 18:55

    I would prefer that you didn't submit this Roland, openid is a third party library and can be left out for the CGL. Can you repush this patch wihtout openid?
  12. Christian Kuhn commented on patch set 5 V 0 10/28/12, 18:55

    by team member; Looks good to me, approved
  13. Christian Kuhn merged patch set 5 10/28/12, 18:55