Review main Merged

15257[BUGFIX] Allow overwrite when uploading an existing extension

Kai Richter CR +2 V +2 Normal +143 −92 updated 06/03/13, 20:49

Commit message

This patch adds a checkbox to the upload form, which makes it possible
to overwrite the existing directory when uploading an extension
which is already available in the system.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +1

Issues 1

Files 8

Review log 21

  1. Kai Richter uploaded patch set 2 10/28/12, 16:23

  2. Kai Richter uploaded patch set 3 10/28/12, 16:23

  3. Kai Richter commented on patch set 3 10/28/12, 16:23

    Removed push method to move extension keys to the end of the extension list when overwriting an existing extension.
  4. Helmut Hummel uploaded patch set 5 10/28/12, 16:23

  5. Helmut Hummel uploaded patch set 6 10/28/12, 16:23

  6. Helmut Hummel commented on patch set 6 10/28/12, 16:23

    Verified; Looks good to me, but someone else must approve * rebased * left the ajax action to avoid troubles while reloading the extension list * changed the check from loaded extension to available extension * added translations
  7. Christian Kuhn commented on patch set 4 10/28/12, 16:23

    I would prefer that you didn't submit this Sorry, we were not quick enough ... patch needs a rebase after recent em changes in master.
  8. Kai Richter uploaded patch set 4 10/28/12, 16:23

  9. Mattias Nilsson commented on patch set 4 10/28/12, 16:23

    Verified; Looks good to me, but someone else must approve
  10. Anja Leichsenring commented on patch set 1 V 0 10/28/12, 16:23

    upload.js:14

    delete this line, it will cause trouble
  11. Anja Leichsenring commented on patch set 2 10/28/12, 16:23

    Verified; Looks good to me, but someone else must approve
  12. Anja Leichsenring commented on patch set 4 10/28/12, 16:23

    Verified; Looks good to me, but someone else must approve
  13. Mr. Jenkins commented on patch set 1 10/28/12, 16:23

  14. Mr. Jenkins commented on patch set 2 10/28/12, 16:23

  15. Mr. Jenkins commented on patch set 3 10/28/12, 16:23

  16. Mr. Jenkins commented on patch set 4 10/28/12, 16:23

  17. Mr. Jenkins commented on patch set 5 10/28/12, 16:23

  18. Mr. Jenkins commented on patch set 6 10/28/12, 16:23

  19. Wouter Wolters commented on patch set 4 10/28/12, 16:23

    Looks good to me, but someone else must approve
  20. Christian Kuhn commented on patch set 6 V 0 10/28/12, 16:23

    by team member; Looks good to me, approved
  21. Christian Kuhn merged patch set 6 10/28/12, 16:23