15257[BUGFIX] Allow overwrite when uploading an existing extension
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Helmut Hummel +1
Issues 1
Files 8
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+10 −0
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+0 −9
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+46 −29
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+47 −23
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/UploadExtensionFile/Extract.json+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/UploadExtensionFile/Form.html+5 −4
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/upload.js1+28 −26
Review log 21
-
Kai Richter uploaded patch set 2 10/28/12, 16:23
-
Kai Richter uploaded patch set 3 10/28/12, 16:23
-
Kai Richter commented on patch set 3 10/28/12, 16:23
Removed push method to move extension keys to the end of the extension list when overwriting an existing extension. -
Helmut Hummel uploaded patch set 5 10/28/12, 16:23
-
Helmut Hummel uploaded patch set 6 10/28/12, 16:23
-
Helmut Hummel commented on patch set 6 10/28/12, 16:23
Verified; Looks good to me, but someone else must approve * rebased * left the ajax action to avoid troubles while reloading the extension list * changed the check from loaded extension to available extension * added translations -
Christian Kuhn commented on patch set 4 10/28/12, 16:23
I would prefer that you didn't submit this Sorry, we were not quick enough ... patch needs a rebase after recent em changes in master. -
Kai Richter uploaded patch set 4 10/28/12, 16:23
-
Mattias Nilsson commented on patch set 4 10/28/12, 16:23
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 1 V 0 10/28/12, 16:23
upload.js:14delete this line, it will cause trouble -
Anja Leichsenring commented on patch set 2 10/28/12, 16:23
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 4 10/28/12, 16:23
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 10/28/12, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6123/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/28/12, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6124/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/28/12, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6182/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/28/12, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6253/ : SUCCESS -
Mr. Jenkins commented on patch set 5 10/28/12, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6419/ : SUCCESS -
Mr. Jenkins commented on patch set 6 10/28/12, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6420/ : SUCCESS -
Wouter Wolters commented on patch set 4 10/28/12, 16:23
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 6 V 0 10/28/12, 16:23
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 6 10/28/12, 16:23