Review main Merged

1531[BUGFIX] Display correct lost records count in record statistics

Susi Moog CR +2 V +2 Easy +7 −1 updated 06/03/13, 20:49

Commit message

The module DB Check > Record statistics counts the deleted pages
instead of the lost pages and displays that number. As the links
for adopting orphaned records should correlate to the count of
lost records, we should display the correct number.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 11

  1. Stefan Neufeind commented on patch set 2 05/08/11, 10:49

    Looks good to me, but someone else must approve
  2. Stefan Neufeind voted on patch set 2 V 0 05/08/11, 10:49

  3. Susi Moog uploaded patch set 2 05/08/11, 10:49

  4. Christian Kuhn commented on patch set 2 05/08/11, 10:49

    Verified; Looks good to me, but someone else must approve
  5. Christian Kuhn commented on patch set 2 05/08/11, 10:49

    @Stefan: Thanks for your vote! If you could give an additional "+1 Verified" (this means "I have tested this patch successful"), this patch set could be ready to commit.
  6. Philipp Gampe commented on patch set 2 05/08/11, 10:49

    While testing... it seems that $BACK_PATH is not defined at all which makes the urls to the icons wrong. Through path works
  7. Philipp Gampe commented on patch set 2 05/08/11, 10:49

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 05/08/11, 10:49

  9. Mr. Jenkins commented on patch set 2 05/08/11, 10:49

  10. Steffen Gebert commented on patch set 2 V 0 05/08/11, 10:49

    by team member; Looks good to me, approved Submitted (without additional review) as there are enough votes (Christian counts as +2).
  11. Steffen Gebert merged patch set 2 05/08/11, 10:49