Review main Merged

15321[BUGFIX] Root-level folders cannot be displayed

Andreas Wolf CR +2 V +2 Normal +45 −36 updated 06/03/13, 20:49

Commit message

Due to a recent fix in the folder resolving mechanism, the root-level
folders of a storage were not displayed anymore in the file list module.

This commit re-enables displaying rootlevel folders, at the expense of
removing the hierarchy resolving (i.e., we now always choose the
root-level folder of a storage instead of the next higher level. This
concept was broken anyways, as folders do not need to be in a hierarchy.
Thus we cannot use such a simple resolving mechanism, but have to
implement that per driver instead.

There is currently no permission check in the file list controller, so
both the selected folder and the (fallback) root-level folder might be
displayed though the user has no permission to do so.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 2

Review log 12

  1. Andreas Wolf uploaded patch set 2 10/09/12, 10:07

  2. Andreas Wolf uploaded patch set 3 10/09/12, 10:07

  3. Benni Mack commented on patch set 3 10/09/12, 10:07

    Verified; Looks good to me, but someone else must approve
  4. Helmut Hummel uploaded patch set 4 10/09/12, 10:07

  5. Helmut Hummel commented on patch set 4 V 0 10/09/12, 10:07

    by team member; Looks good to me, approved Only rebased, counting Benni's vote to be still valid
  6. Philipp Gampe commented on patch set 3 10/09/12, 10:07

    (2 inline comments)

    ResourceFactory.php:363

    $storageUid might not always be defined. Either remove the safety check above or add an else clause to raise an exception.

    FileListController.php:94

    this line is ugly (double assignment)
  7. Philipp Gampe commented on patch set 3 10/09/12, 10:07

    needs a rebase
  8. Mr. Jenkins commented on patch set 1 10/09/12, 10:07

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6145/ : FAILURE
  9. Mr. Jenkins commented on patch set 2 10/09/12, 10:07

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6146/ : FAILURE
  10. Mr. Jenkins commented on patch set 3 10/09/12, 10:07

  11. Mr. Jenkins commented on patch set 4 10/09/12, 10:07

  12. Helmut Hummel merged patch set 4 10/09/12, 10:07