15321[BUGFIX] Root-level folders cannot be displayed
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
-
Verified V +2
- Helmut Hummel +2
Issues 1
Files 2
Review log 12
-
Andreas Wolf uploaded patch set 2 10/09/12, 10:07
-
Andreas Wolf uploaded patch set 3 10/09/12, 10:07
-
Benni Mack commented on patch set 3 10/09/12, 10:07
Verified; Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 4 10/09/12, 10:07
-
Helmut Hummel commented on patch set 4 V 0 10/09/12, 10:07
by team member; Looks good to me, approved Only rebased, counting Benni's vote to be still valid -
Philipp Gampe commented on patch set 3 10/09/12, 10:07
(2 inline comments)ResourceFactory.php:363$storageUid might not always be defined. Either remove the safety check above or add an else clause to raise an exception.FileListController.php:94this line is ugly (double assignment) -
Philipp Gampe commented on patch set 3 10/09/12, 10:07
needs a rebase -
Mr. Jenkins commented on patch set 1 10/09/12, 10:07
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6145/ : FAILURE -
Mr. Jenkins commented on patch set 2 10/09/12, 10:07
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6146/ : FAILURE -
Mr. Jenkins commented on patch set 3 10/09/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6147/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/09/12, 10:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6193/ : SUCCESS -
Helmut Hummel merged patch set 4 10/09/12, 10:07