Review main Merged

15393[TASK] Add docheader to module "about TYPO3"

Georg Ringer CR +2 V +2 Easy +11 −4 updated 06/03/13, 20:49

Commit message

The about module is missing the docheader, IMO the only
BE module where this is missing.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Mattias Nilsson +1
    • Felix Kopp +1
  • Verified V +2
    • Georg Ringer +2
    • Felix Kopp +1

Issues 1

Files 2

Review log 9

  1. Georg Ringer merged patch set 1 10/08/12, 15:31

  2. Christian Kuhn commented on patch set 2 10/08/12, 15:31

    +1 ... btw: "TYPO3 Manual" misses docheader, too ...
  3. Georg Ringer commented on patch set 2 V 0 10/08/12, 15:31

    by team member; Looks good to me, approved
  4. Felix Kopp commented on patch set 2 10/08/12, 15:31

    Verified; Looks good to me, but someone else must approve Also adjusts to the standard #typo3-inner-docbody module in other views.
  5. Felix Kopp uploaded patch set 2 10/08/12, 15:31

  6. Mattias Nilsson commented on patch set 2 10/08/12, 15:31

    Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 10/08/12, 15:31

  8. Mr. Jenkins commented on patch set 2 10/08/12, 15:31

  9. Felix Kopp commented on patch set 2 10/08/12, 15:31

    The manual is a bit complicated since the single topics are also opened in popups. In my opinion the whole manual part should become a "help center" that is designed differently.