15399[BUGFIX] Consider localizeReferencesAtParentLocalization for group/db
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/core/Classes/DataHandling/DataHandler.php10+22 −10
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csvnew+33 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/ActionTest.php+15 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Group/AbstractActionTestCase.php+13 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csvnew+33 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/ActionTest.php+15 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Select/AbstractActionTestCase.php+13 −0
Review log 4765
Show 3240 earlier messages
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6175/ : SUCCESS -
Oliver Hader wrote 10/09/13, 16:50
Topic updated from "41713" to "overlay-api". -
Oliver Hader wrote 10/09/13, 16:50
Topic updated from "overlay-api" to "DataHandler-API". -
Benni Mack uploaded patch set 2 01/07/15, 16:53
-
Benni Mack wrote 01/07/15, 16:54
Topic changed from DataHandler-API to IRRE -
Mathias Brodala commented on patch set 2 CR -1 01/08/15, 08:03
DataHandler.php:3301Please use the shortened version which is already "use"d. -
Benni Mack uploaded patch set 3 01/08/15, 11:54
-
Benni Mack wrote 02/02/15, 21:16
Topic changed from IRRE to DataHandler -
Benni Mack uploaded patch set 4 02/02/15, 21:19
-
Andreas Wolf uploaded patch set 5 08/05/15, 11:23
-
Andreas Wolf uploaded patch set 6 08/05/15, 11:31
-
Andreas Wolf commented on patch set 6 08/05/15, 11:32
Rebased, added functional test and removed an issue with Oliver’s patch relating to the functional test. There are still uncovered use cases, this still needs more love! -
Andreas Wolf uploaded patch set 7 08/05/15, 13:49
-
Andreas Wolf uploaded patch set 8 03/03/16, 14:51
-
Andreas Wolf commented on patch set 8 03/03/16, 15:19
Rebased once again…DataHandler.php:3082I'd rather call this $tableLocalizationStatus. $localizeTables does not really convey the intended meaning here. -
Benni Mack commented on patch set 8 03/04/16, 16:00
should be master and 7.6 then, right? -
Nicole Hummel commented on patch set 8 03/04/16, 16:16
7.6 missingDataHandler.php:3685trueDataHandler.php:3693[];DataHandler.php:3702maybe !empty()DataHandler.php:3703!empty()DataHandler.php:3716empty()DataHandler.php:3725IMHO this is already checked with the flal through from aboveext_tables.php:76aext_tables.sql:9should be intext_tables.sql:11should be int -
Andreas Wolf uploaded patch set 9 03/06/16, 15:05
-
Andreas Wolf uploaded patch set 10 09/02/16, 16:22
-
Andreas Wolf uploaded patch set 11 09/02/16, 16:31
-
TYPO3com voted on patch set 11 V -1 12/04/16, 10:10 Completed build in 05m 57s on Sun, 4 Dec, 11:10 AM Test Summary: 270 of 54330 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5451
-
Oliver Hader abandoned the change 10/19/17, 20:52
Still an issue, however I cannot solve that on my own. Closed due to lack of feedback -
Oliver Hader restored the change 01/23/18, 20:50
WIP -
Oliver Hader updated the commit message in patch set 12 01/23/18, 20:50
-
TYPO3com voted on patch set 12 V -1 01/23/18, 20:51 Completed build in 07s on Tue, 23 Jan, 09:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18562
-
Oliver Hader updated the commit message in patch set 13 01/23/18, 20:51
-
TYPO3com voted on patch set 13 V -1 01/23/18, 20:51 Completed build in 08s on Tue, 23 Jan, 09:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18563
-
Andreas Wolf uploaded patch set 14 01/27/18, 19:28
-
Andreas Wolf uploaded patch set 15 01/27/18, 19:35
-
TYPO3com voted on patch set 14 V -1 01/27/18, 19:36 Completed build in 07m 52s on Sat, 27 Jan, 08:36 PM Test Summary: 306 of 30521 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18666
-
TYPO3com voted on patch set 15 V -1 01/27/18, 19:41 Completed build in 05m 56s on Sat, 27 Jan, 08:41 PM Test Summary: 4 of 30521 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18667
-
Andreas Wolf rebased onto patch set 16 03/17/18, 15:34
-
TYPO3com voted on patch set 16 V -1 03/17/18, 15:45 Completed build in 10m 43s on Sat, 17 Mar, 04:45 PM Test Summary: 4 of 31042 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21508
-
Andreas Wolf uploaded patch set 17 03/17/18, 15:47
-
TYPO3com voted on patch set 17 V +1 03/17/18, 15:58 Completed build in 10m 03s on Sat, 17 Mar, 04:58 PM Test Summary: 30890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21513
-
Oliver Hader commented on patch set 17 05/03/18, 15:43
Check and streamline concerning https://docs.typo3.org/typo3cms/TCAReference/ColumnsConfig/Type/Group.html#localizereferencesatparentlocalizationDataHandler.php:3088asdasd -
Nicole Hummel commented on patch set 17 05/03/18, 16:11
DataHandler.php:3960unsetting the item that is used in foreach loop may result in unexpected behaviour. -
Benni Mack uploaded patch set 18 10/30/18, 21:04
-
TYPO3com voted on patch set 18 V +1 10/30/18, 21:16 Completed build in 11m 47s on Tue, 30 Oct, 10:16 PM Test Summary: 48431 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29904
-
Benni Mack updated the commit message in patch set 19 12/14/18, 10:05
-
Benni Mack commented on patch set 19 12/14/18, 10:05
Updated the releases line, please re-apply your votes -
TYPO3com voted on patch set 19 V +1 12/14/18, 11:18 Completed build in 23m 33s on Fri, 14 Dec, 12:18 PM Test Summary: 48769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30700
-
Oliver Hader rebased onto patch set 20 01/30/19, 15:57
-
TYPO3com voted on patch set 20 V +1 01/30/19, 16:17 Completed build in 20m 24s on Wed, 30 Jan, 05:17 PM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31841
-
Benni Mack uploaded patch set 21 12/27/19, 20:52
-
TYPO3com voted on patch set 21 V -1 12/27/19, 21:23 Completed build in 28m 53s on Fri, 27 Dec, 09:23 PM Test Summary: 2 of 67899 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39613
-
Nikita Hovratov uploaded patch set 22 07/23/21, 18:15
-
core-ci voted on patch set 22 V -1 07/23/21, 18:18 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13698
-
Nikita Hovratov commented on patch set 22 07/23/21, 18:20
Maybe we can bring this to life again? Not so easy to comprehend, what was going on the last 8 years, but I think the logic in DataHandler is correct now. Needing some help with the tests though. I adjusted the obvious errors, but somehow the localizeRecord action doesn't return anything. -
Nikita Hovratov uploaded patch set 23 07/23/21, 18:28
-
core-ci voted on patch set 23 V -1 07/23/21, 18:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13699
-
Nikita Hovratov uploaded patch set 24 07/23/21, 20:20
-
core-ci voted on patch set 24 V +1 07/23/21, 20:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13700
-
Nikita Hovratov uploaded patch set 25 07/23/21, 20:41
-
Nikita Hovratov commented on patch set 25 07/23/21, 20:45
I just happened to have already created tests for this: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69904 They should be now state of the art. Please have a look, if I forgot something in the old tests. -
core-ci voted on patch set 25 V +1 07/23/21, 20:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13701
-
Christian Kuhn commented on patch set 25 11/05/21, 12:55
related: some tests are added here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69904 -
Christian Kuhn commented on patch set 25 11/05/21, 12:56
related patch adds some tests already https://review.typo3.org/c/Packages/TYPO3.CMS/+/69904 -
Benni Mack updated the commit message in patch set 26 11/08/21, 18:38
-
core-ci voted on patch set 26 V +1 11/08/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19039
-
Nikita Hovratov uploaded patch set 27 11/09/21, 08:17
-
Nikita Hovratov updated the commit message in patch set 28 11/09/21, 08:20
-
core-ci voted on patch set 27 V +1 11/09/21, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19057
-
core-ci voted on patch set 28 V +1 11/09/21, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19058
-
Christian Kuhn abandoned the change 11/09/21, 18:50