Review main Merged

15427[TASK] File: add getNameWithoutExtension() method

Andreas Wolf CR +2 V +2 Normal +56 −1 updated 06/03/13, 20:49

Commit message

There is currently no way to get the filename without its extension,
e.g. to create a new name for a file converted to another format. This
commits adds such a method, together with tests and a fix for names like
somefile.tar.gz.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 3

Review log 8

  1. Benni Mack commented on patch set 1 10/10/12, 14:05

    Verified; Looks good to me, but someone else must approve
  2. Steffen Ritter uploaded patch set 2 10/10/12, 14:05

  3. Steffen Ritter uploaded patch set 3 10/10/12, 14:05

  4. Steffen Ritter commented on patch set 3 V 0 10/10/12, 14:05

    by team member; Looks good to me, approved merged after fixing the issue discussed in group review with Helmut, Olly and Andreas
  5. Mr. Jenkins commented on patch set 1 10/10/12, 14:05

  6. Mr. Jenkins commented on patch set 2 10/10/12, 14:05

  7. Mr. Jenkins commented on patch set 3 10/10/12, 14:05

  8. Steffen Ritter merged patch set 3 10/10/12, 14:05