Review main Merged

15436[BUG] Deleting a file is impossible after it was used

Benni Mack CR +2 V +2 Easy +7 −2 updated 06/03/13, 20:49

Commit message

The sys_refindex db table has a deleted column which is set
however when deleting a file, extfilefunc mentions that the
file is still in use. The extfilefunc check now takes the deleted
column into account.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2
    • Steffen Ritter +1

Issues 1

Files 1

Review log 8

  1. Helmut Hummel commented on patch set 1 10/09/12, 16:05

    (1 inline comment)

    ExtendedFileUtility.php:391

    we should add an intval here!
  2. Helmut Hummel commented on patch set 2 V 0 10/09/12, 16:05

    by team member; Looks good to me, approved
  3. Helmut Hummel uploaded patch set 2 10/09/12, 16:05

  4. Steffen Ritter commented on patch set 1 10/09/12, 16:05

    Looks good to me, but someone else must approve
  5. Steffen Ritter commented on patch set 2 10/09/12, 16:05

    Verified; Looks good to me, approved
  6. Mr. Jenkins commented on patch set 1 10/09/12, 16:05

  7. Mr. Jenkins commented on patch set 2 10/09/12, 16:05

  8. Helmut Hummel merged patch set 2 10/09/12, 16:05