Review main Merged

15446[BUGFIX] Use UTF-8 by default in Flexforms and Backend

Benni Mack CR +2 V +2 Easy +7 −16 updated 06/03/13, 20:49

Commit message

For FlexForm tools (used internally) and for backend
use, the encoding is always utf-8, so some checks
can be removed and functions can be deprecated.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
  • Verified V +2
    • Dmitry Dulepov +2

Issues 1

Files 4

Review log 7

  1. Dmitry Dulepov commented on patch set 2 V 0 10/15/12, 11:47

    by team member; Looks good to me, but someone else must approve Tested, works fine. I had only two very minor notes.

    LocalDriver.php:258

    Shouldn't we get rid of "best guess" part?

    BasicFileUtility.php:525

    Again, no "best guess" needed.
  2. Dmitry Dulepov uploaded patch set 3 10/15/12, 11:47

  3. Benni Mack uploaded patch set 2 10/15/12, 11:47

  4. Mr. Jenkins commented on patch set 1 10/15/12, 11:47

  5. Mr. Jenkins commented on patch set 2 10/15/12, 11:47

  6. Dmitry Dulepov commented on patch set 3 V 0 10/15/12, 11:47

    by team member; Looks good to me, approved
  7. Dmitry Dulepov merged patch set 3 10/15/12, 11:47