15465[TASK] Extension Manager: Add icons including titles, with CSS-classes
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 20
- typo3/sysext/core/Classes/Resource/Service/FrontendContentAdapterService.php+0 −5
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConfigureExtensionViewHelper.php+14 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionDataViewHelper.php+14 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+14 −4
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+12 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerShowVersionsTable.html+9 −11
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerTable.html+2 −4
- typo3/sysext/extensionmanager/Resources/Private/Scss/page/_manage.scss+38 −0
- typo3/sysext/extensionmanager/Resources/Private/Scss/main.scss+0 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.html+2 −2
- typo3/sysext/extensionmanager/Resources/Public/Css/main.css+22 −0
- typo3/sysext/extensionmanager/Resources/Public/Images/activate.pngnewbinary
- typo3/sysext/extensionmanager/Resources/Public/Images/configure.pngnewbinary
- typo3/sysext/extensionmanager/Resources/Public/Images/deactivate.pngnewbinary
- typo3/sysext/extensionmanager/Resources/Public/Images/download-sql.pngnewbinary
- typo3/sysext/extensionmanager/Resources/Public/Images/download.pngnewbinary
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+35 −20
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+33 −9
- typo3/sysext/rtehtmlarea/htmlarea/htmlarea.js+3 −2
Review log 7
-
Hans Christian Reinl commented on patch set 2 10/09/12, 22:34
Abandoned Uffz, thanks Wouters. This just got a bit confusing, as I committed stuff that I didn't want to have. Closing. Sorry! -
Hans Christian Reinl uploaded patch set 2 10/09/12, 22:34
-
Mr. Jenkins commented on patch set 1 10/09/12, 22:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6215/ : FAILURE -
Mr. Jenkins commented on patch set 2 10/09/12, 22:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6218/ : SUCCESS -
Wouter Wolters commented on patch set 1 10/09/12, 22:34
Hey Hans, Thanks for the patch:) Jenkins is downvoting this patch because the Commit-message is to long. Each line has a maximum of 74 characters. -
Wouter Wolters commented on patch set 2 10/09/12, 22:34
No problem:) I already reviewed the other patch and was just hitting the vote button. See my comment below. Looks really good! The download as zip icon has a gray background when on a white row. Same for the download SQL Dump. The install and uninstall are good:) -
Hans Christian Reinl commented on patch set 2 10/09/12, 22:34
Thanks for the info. And sorry for writing your name wrong. I'm really confused with this interface :D Couldn't find help in the IRC channel :( The problem with the icons: I'm not aware of a repository of icons and I still got a screenshot from the designers. Will get into contact with Susanne about this. I think I'll have to resubmit this PR?! Will talk to my colleague at work tomorrow. Hopefully he can help me ;) Thank you for your appreciation! :)