Review main Abandoned

15465[TASK] Extension Manager: Add icons including titles, with CSS-classes

Hans Christian Reinl CR 0 V 0 Hard +199 −63 updated 06/03/13, 20:49

Commit message

Add icons installing, uninstalling, downloading aso. for Extension
manager, add better class-names, add titles on links.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 20

Review log 7

  1. Hans Christian Reinl commented on patch set 2 10/09/12, 22:34

    Abandoned Uffz, thanks Wouters. This just got a bit confusing, as I committed stuff that I didn't want to have. Closing. Sorry!
  2. Hans Christian Reinl uploaded patch set 2 10/09/12, 22:34

  3. Mr. Jenkins commented on patch set 1 10/09/12, 22:34

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6215/ : FAILURE
  4. Mr. Jenkins commented on patch set 2 10/09/12, 22:34

  5. Wouter Wolters commented on patch set 1 10/09/12, 22:34

    Hey Hans, Thanks for the patch:) Jenkins is downvoting this patch because the Commit-message is to long. Each line has a maximum of 74 characters.
  6. Wouter Wolters commented on patch set 2 10/09/12, 22:34

    No problem:) I already reviewed the other patch and was just hitting the vote button. See my comment below. Looks really good! The download as zip icon has a gray background when on a white row. Same for the download SQL Dump. The install and uninstall are good:)
  7. Hans Christian Reinl commented on patch set 2 10/09/12, 22:34

    Thanks for the info. And sorry for writing your name wrong. I'm really confused with this interface :D Couldn't find help in the IRC channel :( The problem with the icons: I'm not aware of a repository of icons and I still got a screenshot from the designers. Will get into contact with Susanne about this. I think I'll have to resubmit this PR?! Will talk to my colleague at work tomorrow. Hopefully he can help me ;) Thank you for your appreciation! :)