Review main Merged

15499[TASK] Extension Manager: Add icons and language labels

Wouter Wolters CR +2 V +2 Hard +542 −440 updated 06/03/13, 20:49

Commit message

Add icons and language labels for Extension manager, titles on links.
Move text from templates to language labels.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Jigal van Hemert +1
  • Verified V +2
    • Helmut Hummel +2
    • Anja Leichsenring +1
    • Jigal van Hemert +1

Issues 1

Files 18

Review log 13

  1. Helmut Hummel merged patch set 1 10/15/12, 20:37

  2. Jigal van Hemert commented on patch set 1 10/15/12, 20:37

    Do not submit The core uses sprites for icons. The labels should not be hardcoded texts but localized strings. Will push a new version.
  3. Helmut Hummel commented on patch set 2 V 0 10/15/12, 20:37

    by team member; Looks good to me, approved
  4. Jigal van Hemert commented on patch set 2 10/15/12, 20:37

    Verified; Looks good to me, but someone else must approve Used icons from sprite, added some new icons, replaced text in template with language labels. NOTE: new sprite image + sprite CSS are included in patch to ease testing. Sprite and CSS are regenerated before release, so these can be ignored when reviewing by reading.
  5. Jigal van Hemert uploaded patch set 2 10/15/12, 20:37

  6. Philipp Gampe commented on patch set 1 10/15/12, 20:37

    Great work so far <3 the configure image is 17 pixel high ?! the download-sql, download ones too In the configure subpage, the back to list link (top) is missing and it should be one row below The upload extension could have an icon in front of it. Not your fault I guess, but the search field misses a clear icon/function. Strip the Signed-off-by: line, we don't need this, because everything is linked via gerrit (and forge)
  7. Mattias Nilsson commented on patch set 1 10/15/12, 20:37

    Verified; Looks good to me, but someone else must approve
  8. Anja Leichsenring commented on patch set 2 10/15/12, 20:37

    Verified; Looks good to me, but someone else must approve Looks very nice with the icons in place. Thank you for this work.
  9. Hans Christian Reinl commented on patch set 1 10/15/12, 20:37

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 10/15/12, 20:37

  11. Mr. Jenkins commented on patch set 2 10/15/12, 20:37

  12. Wouter Wolters commented on patch set 1 10/15/12, 20:37

    Verified; Looks good to me, but someone else must approve Resubmitted for Hans Christian.
  13. Felix Kopp commented on patch set 2 10/15/12, 20:37

    Very nice!