15550[FEATURE] Add several testcases for validators
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 22
- typo3/sysext/form/Classes/System/Validate/Abstract.php+12 −2
- typo3/sysext/form/Tests/Unit/System/Validate/AlphabeticTest.phpnew+161 −0
- typo3/sysext/form/Tests/Unit/System/Validate/AlphanumericTest.phpnew+161 −0
- typo3/sysext/form/Tests/Unit/System/Validate/BetweenTest.phpnew+166 −0
- typo3/sysext/form/Tests/Unit/System/Validate/DateTest.phpnew+105 −0
- typo3/sysext/form/Tests/Unit/System/Validate/DigitTest.phpnew+101 −0
- typo3/sysext/form/Tests/Unit/System/Validate/EmailTest.phpnew+102 −0
- typo3/sysext/form/Tests/Unit/System/Validate/EqualsTest.phpnew+80 −0
- typo3/sysext/form/Tests/Unit/System/Validate/FileallowedtypesTest.phpnew+103 −0
- typo3/sysext/form/Tests/Unit/System/Validate/FilemaximumsizeTest.phpnew+102 −0
- typo3/sysext/form/Tests/Unit/System/Validate/FileminimumsizeTest.phpnew+102 −0
- typo3/sysext/form/Tests/Unit/System/Validate/FloatTest.phpnew+78 −0
- typo3/sysext/form/Tests/Unit/System/Validate/GreaterthanTest.phpnew+103 −0
- typo3/sysext/form/Tests/Unit/System/Validate/Helper.phpnew+85 −0
- typo3/sysext/form/Tests/Unit/System/Validate/InarrayTest.phpnew+137 −0
- typo3/sysext/form/Tests/Unit/System/Validate/IntegerTest.phpnew+102 −0
- typo3/sysext/form/Tests/Unit/System/Validate/IpTest.phpnew+104 −0
- typo3/sysext/form/Tests/Unit/System/Validate/LengthTest.phpnew+107 −0
- typo3/sysext/form/Tests/Unit/System/Validate/LessthanTest.phpnew+102 −0
- typo3/sysext/form/Tests/Unit/System/Validate/RegexpTest.phpnew+101 −0
Review log 4
-
Stefan Neufeind commented on patch set 1 03/01/13, 11:04
Looks good to me, but someone else must approve Briefly looked and it and seems to be what was submitted for 4.7 and 6.0. Since it's "only" testcases and since it seems Steffen was able to execute them fine I guess we should be safe to go with these. -
Xavier Perseguers commented on patch set 1 03/01/13, 11:04
Fails Failure on a few tests -
Steffen Ritter commented on patch set 1 03/01/13, 11:04
Verified; Looks good to me, but someone else must approve will get green using other pending form fixes -
Oliver Hader commented on patch set 1 03/01/13, 11:04
Abandoned TYPO3 4.6 branch is at the end of bug fixing period. Only priority changes will be considered (compatibility fixes and security fixes) until end of April 2013.