Review main Merged

15836[BUGFIX] Storage uses wrong identifier for processing folder

Andreas Wolf CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

All absolute identifiers within a storage have to begin with a "/". The
Storage does not respect this for the processing folder, leading to
wrong identifiers being generated for images inside this folder.

To account for this change, the sys_file_processedfile table should be
cleared. All identifiers will be regenerated then.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 1

Review log 6

  1. Andreas Wolf uploaded patch set 2 10/21/12, 13:37

  2. Steffen Ritter commented on patch set 1 10/21/12, 13:37

    I would prefer that you didn't submit this Not sure if it is complete, see inline comment

    ResourceStorage.php:1961

    if a leading slash is required - why isnt that change done before "folderExist" is called - therefore line 1948 changed
  3. Mr. Jenkins commented on patch set 1 10/21/12, 13:37

  4. Mr. Jenkins commented on patch set 2 10/21/12, 13:37

  5. Steffen Ritter commented on patch set 2 V 0 10/21/12, 13:37

    by team member; Looks good to me, approved no brainer, thx
  6. Steffen Ritter merged patch set 2 10/21/12, 13:37