Review main Merged

15838[BUGFIX] Create upload folder on extension install

Helmut Hummel CR +2 V +2 Hard +305 −67 updated 06/03/13, 20:49

Commit message

Implement the creation of configured upload folder 
and "createDirs".

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 7

  1. Helmut Hummel uploaded patch set 2 10/20/12, 20:22

  2. Helmut Hummel commented on patch set 2 V 0 10/20/12, 20:22

    by team member; Looks good to me, approved
  3. Mr. Jenkins commented on patch set 1 10/20/12, 20:22

  4. Mr. Jenkins commented on patch set 2 10/20/12, 20:22

  5. Wouter Wolters commented on patch set 1 10/20/12, 20:22

    (2 inline comments)

    FileHandlingUtility.php:208

    boolean

    FileHandlingUtility.php:240

    missing type
  6. Wouter Wolters commented on patch set 2 10/20/12, 20:22

    Verified; Looks good to me, but someone else must approve
  7. Helmut Hummel merged patch set 2 10/20/12, 20:22