15838[BUGFIX] Create upload folder on extension install
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Wouter Wolters +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
Issues 1
Files 5
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php2+104 −18
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+20 −12
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+137 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+44 −35
- typo3/sysext/extensionmanager/ext_emconf.php+0 −1
Review log 7
-
Helmut Hummel uploaded patch set 2 10/20/12, 20:22
-
Helmut Hummel commented on patch set 2 V 0 10/20/12, 20:22
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 10/20/12, 20:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6365/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/20/12, 20:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6368/ : SUCCESS -
Wouter Wolters commented on patch set 1 10/20/12, 20:22
(2 inline comments)FileHandlingUtility.php:208booleanFileHandlingUtility.php:240missing type -
Wouter Wolters commented on patch set 2 10/20/12, 20:22
Verified; Looks good to me, but someone else must approve -
Helmut Hummel merged patch set 2 10/20/12, 20:22