Review main Merged

15840[BUGFIX] EM: uploading extension form must go to iframe

Jigal van Hemert CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

In some browsers the upload form did not go to the iframe for further
processing by JavaScript. Adding a name to the iframe solves the
problem.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Files 1

Review log 7

  1. Helmut Hummel commented on patch set 1 V 0 10/20/12, 18:05

    by team member; Looks good to me, approved
  2. Helmut Hummel commented on patch set 1 V 0 10/20/12, 18:05

    by team member; Looks good to me, approved
  3. Helmut Hummel commented on patch set 1 10/20/12, 18:05

    No score; No score
  4. Jigal van Hemert uploaded patch set 2 10/20/12, 18:05

  5. Mr. Jenkins commented on patch set 1 10/20/12, 18:05

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6366/ : FAILURE
  6. Jigal van Hemert commented on patch set 2 V 0 10/20/12, 18:05

    by team member; Looks good to me, approved
  7. Jigal van Hemert merged patch set 2 10/20/12, 18:05