1586[BUGFIX] Determine correct preview flag, if page is access restricted
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 3
Files 1
Review log 13
-
Steffen Gebert commented on patch set 1 02/01/12, 00:18
I would prefer that you didn't submit this Thanks for the patch, Frederic. Sounds very helpful! As commit messages will live in our history for ever, sorry for the nit-picking. You might want to configure your IDE to show white-spaces (or to strip trailing white-space on modified lines).corret -> correctwether -> whetheronline -> only (?)class.tslib_fe.php:788lot of trailing white-spaces -
Björn Pedersen commented on patch set 2 02/01/12, 00:18
(1 inline comment) See inline comment: Is it really necessary to create so many pageSelect instances here? -
Stefan Neufeind commented on patch set 2 1 comment 02/01/12, 00:18
Looks good to me, but someone else must approve Just by looking at it, that might possibly work :-) -
Steffen Gebert uploaded patch set 2 02/01/12, 00:18
-
Björn Pedersen commented on patch set 3 02/01/12, 00:18
Looks good to me, but someone else must approve -
Dmitry Dulepov commented on patch set 3 02/01/12, 00:18
Fails; Do not submit The patch is obsolete. It neither apply, nor it solves the issue. Please, see the bug report for more information. -
Frederic Gaus commented on patch set 3 02/01/12, 00:18
Fails; I would prefer that you didn't submit this I found a serious problem in this patch. I debugged this a bit, but the problem is much more complex. So this is only a first step. It still solves #16862 but not the other ones. Further more, it introduces a new bug. Sometimes the preview window is not displayed correctly -
Frederic Gaus uploaded patch set 3 02/01/12, 00:18
-
Frederic Gaus commented on patch set 3 02/01/12, 00:18
Thanks Björn. You're right. The second instance is needless. I updaded a new version. Btw, I also remove the needless whitespace at the line ending. -
Mr. Jenkins commented on patch set 1 02/01/12, 00:18
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/268/ -
Mr. Jenkins commented on patch set 2 02/01/12, 00:18
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/270/ -
Mr. Jenkins commented on patch set 3 02/01/12, 00:18
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1773/ : SUCCESS -
Steffen Gebert commented on patch set 3 02/01/12, 00:18
Abandoned Abandoned due to lack of feedback or activity.