Review main Abandoned

1586[BUGFIX] Determine correct preview flag, if page is access restricted

Frederic Gaus CR 0 V 0 Easy +17 −7 updated 06/03/13, 20:49

Commit message

If a page is access-restricted and the user is logged into the backend,
the page is displayed as a preview. To determine whether the page is
access restricted or not, it is not correct to only check whether
the page is hidden or not.

The patch implements a two level check. For the first level the page
is simply checked for some access-restriction. This is enough to set the
preview flag.

On the second level the pages in the rootline are checked for some
access restriction and if the flag 'extendToSubpages' is set, the
preview flag is also set.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 1

Review log 13

  1. Steffen Gebert commented on patch set 1 02/01/12, 00:18

    I would prefer that you didn't submit this Thanks for the patch, Frederic. Sounds very helpful! As commit messages will live in our history for ever, sorry for the nit-picking. You might want to configure your IDE to show white-spaces (or to strip trailing white-space on modified lines).
    corret -> correct
    wether -> whether
    online -> only (?)

    class.tslib_fe.php:788

    lot of trailing white-spaces
  2. Björn Pedersen commented on patch set 2 02/01/12, 00:18

    (1 inline comment) See inline comment: Is it really necessary to create so many pageSelect instances here?
  3. Stefan Neufeind commented on patch set 2 1 comment 02/01/12, 00:18

    Looks good to me, but someone else must approve Just by looking at it, that might possibly work :-)
  4. Steffen Gebert uploaded patch set 2 02/01/12, 00:18

  5. Björn Pedersen commented on patch set 3 02/01/12, 00:18

    Looks good to me, but someone else must approve
  6. Dmitry Dulepov commented on patch set 3 02/01/12, 00:18

    Fails; Do not submit The patch is obsolete. It neither apply, nor it solves the issue. Please, see the bug report for more information.
  7. Frederic Gaus commented on patch set 3 02/01/12, 00:18

    Fails; I would prefer that you didn't submit this I found a serious problem in this patch. I debugged this a bit, but the problem is much more complex. So this is only a first step. It still solves #16862 but not the other ones. Further more, it introduces a new bug. Sometimes the preview window is not displayed correctly
  8. Frederic Gaus uploaded patch set 3 02/01/12, 00:18

  9. Frederic Gaus commented on patch set 3 02/01/12, 00:18

    Thanks Björn. You're right. The second instance is needless. I updaded a new version. Btw, I also remove the needless whitespace at the line ending.
  10. Mr. Jenkins commented on patch set 1 02/01/12, 00:18

  11. Mr. Jenkins commented on patch set 2 02/01/12, 00:18

  12. Mr. Jenkins commented on patch set 3 02/01/12, 00:18

  13. Steffen Gebert commented on patch set 3 02/01/12, 00:18

    Abandoned Abandoned due to lack of feedback or activity.