Review main Merged

15861[TASK] Prevent multiple processing ContentAdapter

Steffen Ritter CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

The FrontendContentAdapter is triggered everytime a record
is passed to an ContentObject instance. Therefore it may
happen, that the same record is processed by the
FrontendContentAdapter multiple times.

Prevent multiple processing by setting a flag for finished
processing.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Steffen Ritter +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 11/01/12, 10:57

    Looks good to me, but someone else must approve Seems to make sense by reading description and code.
  2. Steffen Ritter commented on patch set 1 V 0 11/01/12, 10:57

    by team member; Looks good to me, approved
  3. Steffen Ritter merged patch set 1 11/01/12, 10:57

  4. Mr. Jenkins commented on patch set 1 11/01/12, 10:57

  5. Wouter Wolters commented on patch set 1 11/01/12, 10:57

    Looks good to me, but someone else must approve
  6. Wouter Wolters voted on patch set 1 V 0 11/01/12, 10:57

  7. Oliver Hader commented on patch set 1 11/01/12, 10:57

    Post-Code-Review: +1 In general we should have unit tests for this class - I've created a task for that, see http://forge.typo3.org/issues/42581