Review main Merged

15877[BUGFIX] EM 6.0 doesn't store extension state from TER

Jigal van Hemert CR +2 V +2 Easy +9 −7 updated 06/03/13, 20:49

Commit message

The extension state is stored as text in the TER dump, but stored as
an integer in the database. The correct conversion must be done to
be able to show the states from extensions in TER.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Helmut Hummel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Helmut Hummel +1

Files 1

Review log 8

  1. Helmut Hummel commented on patch set 1 V 0 10/22/12, 12:44

    Extension.php:355

    strtolower doe not make much sense, when $state is interger, does it? :)
  2. Helmut Hummel uploaded patch set 2 10/22/12, 12:44

  3. Helmut Hummel commented on patch set 2 10/22/12, 12:44

    Verified; Looks good to me, but someone else must approve
  4. Mattias Nilsson commented on patch set 1 10/22/12, 12:44

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 10/22/12, 12:44

  6. Mr. Jenkins commented on patch set 2 10/22/12, 12:44

  7. Jigal van Hemert commented on patch set 2 V 0 10/22/12, 12:44

    by team member; Looks good to me, approved
  8. Jigal van Hemert merged patch set 2 10/22/12, 12:44