1588[FEATURE] Move class "tx_scheduler_Module" from "mod1/index.php" for unit test
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 3
Review log 20
-
Oliver Hader commented on patch set 1 04/16/11, 15:39
Looks good to me, but someone else must approve -
Thomas Maroschik commented on patch set 1 04/16/11, 15:39
I would prefer that you didn't submit this As mentioned in the patch comments. Some XCLASS inclusions are missing and on the other side superflous.class.tx_scheduler_module.php:1603A XCLASS inclusion is missing here.index.php:1611I think we don't need an XCLASS inclusion here anymore. -
Rens Admiraal commented on patch set 2 1 comment 04/16/11, 15:39
I would prefer that you didn't submit this I didn't test the code, but I'm certainly happy with this initiative, would be cool if all multi-class files could be changed ;-) Unfortunately a little whitespace error :-) -
Thomas Maroschik commented on patch set 2 04/16/11, 15:39
Looks good to me, but someone else must approve -
Andy Grunwald uploaded patch set 2 04/16/11, 15:39
-
Stefano Kowalke commented on patch set 3 04/16/11, 15:39
Looks good to me, but someone else must approve -
Rens Admiraal commented on patch set 3 04/16/11, 15:39
Looks good to me, but someone else must approve Code looks good to me -
Thomas Maroschik commented on patch set 3 04/16/11, 15:39
Looks good to me, but someone else must approve -
Andy Grunwald uploaded patch set 3 04/16/11, 15:39
-
Christian Kuhn uploaded patch set 5 04/16/11, 15:39
-
Christian Kuhn commented on patch set 5 V 0 04/16/11, 15:39
by team member; Looks good to me, approved Change is obvious and a nice addition. New patch set just changes the commit message. Since there where enough votes for the previous change already, this version is now submitted to master. -
Stefano Kowalke commented on patch set 4 04/16/11, 15:39
Looks good to me, but someone else must approve -
Stefano Kowalke voted on patch set 4 V 0 04/16/11, 15:39
-
Andy Grunwald uploaded patch set 4 04/16/11, 15:39
-
Mr. Jenkins commented on patch set 1 04/16/11, 15:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/271/ -
Mr. Jenkins commented on patch set 2 04/16/11, 15:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/283/ -
Mr. Jenkins commented on patch set 3 04/16/11, 15:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/286/ -
Mr. Jenkins commented on patch set 4 04/16/11, 15:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/289/ -
Mr. Jenkins commented on patch set 5 04/16/11, 15:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/291/ -
Christian Kuhn merged patch set 5 04/16/11, 15:39