Review main Merged

1588[FEATURE] Move class "tx_scheduler_Module" from "mod1/index.php" for unit test

Andy Grunwald CR +2 V +2 Nightmare +1609 −1589 updated 06/03/13, 20:49

Commit message

This change makes it possible to write unit tests for "tx_scheduler_module".

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 20

  1. Oliver Hader commented on patch set 1 04/16/11, 15:39

    Looks good to me, but someone else must approve
  2. Thomas Maroschik commented on patch set 1 04/16/11, 15:39

    I would prefer that you didn't submit this As mentioned in the patch comments. Some XCLASS inclusions are missing and on the other side superflous.

    class.tx_scheduler_module.php:1603

    A XCLASS inclusion is missing here.

    index.php:1611

    I think we don't need an XCLASS inclusion here anymore.
  3. Rens Admiraal commented on patch set 2 1 comment 04/16/11, 15:39

    I would prefer that you didn't submit this I didn't test the code, but I'm certainly happy with this initiative, would be cool if all multi-class files could be changed ;-) Unfortunately a little whitespace error :-)
  4. Thomas Maroschik commented on patch set 2 04/16/11, 15:39

    Looks good to me, but someone else must approve
  5. Andy Grunwald uploaded patch set 2 04/16/11, 15:39

  6. Stefano Kowalke commented on patch set 3 04/16/11, 15:39

    Looks good to me, but someone else must approve
  7. Rens Admiraal commented on patch set 3 04/16/11, 15:39

    Looks good to me, but someone else must approve Code looks good to me
  8. Thomas Maroschik commented on patch set 3 04/16/11, 15:39

    Looks good to me, but someone else must approve
  9. Andy Grunwald uploaded patch set 3 04/16/11, 15:39

  10. Christian Kuhn uploaded patch set 5 04/16/11, 15:39

  11. Christian Kuhn commented on patch set 5 V 0 04/16/11, 15:39

    by team member; Looks good to me, approved Change is obvious and a nice addition. New patch set just changes the commit message. Since there where enough votes for the previous change already, this version is now submitted to master.
  12. Stefano Kowalke commented on patch set 4 04/16/11, 15:39

    Looks good to me, but someone else must approve
  13. Stefano Kowalke voted on patch set 4 V 0 04/16/11, 15:39

  14. Andy Grunwald uploaded patch set 4 04/16/11, 15:39

  15. Mr. Jenkins commented on patch set 1 04/16/11, 15:39

  16. Mr. Jenkins commented on patch set 2 04/16/11, 15:39

  17. Mr. Jenkins commented on patch set 3 04/16/11, 15:39

  18. Mr. Jenkins commented on patch set 4 04/16/11, 15:39

  19. Mr. Jenkins commented on patch set 5 04/16/11, 15:39

  20. Christian Kuhn merged patch set 5 04/16/11, 15:39