Review main Merged

15886[BUGFIX] Remove singleton for EXT:form Localization

Christian Kuhn CR +2 V +2 Easy +2 −3 updated 06/03/13, 20:49

Commit message

\TYPO3\CMS\Form\Localization is a singleton class with constructor
parameters. This is an antipattern and broken by design. As an effect
it leads to warnings in unit tests and makes the class unusable
with multiple files.

The patch removes the implementation of the singletonInterface, but
sets the default localization file as default parameter to keep
backwards compatibility.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Steffen Ritter +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 6

  1. Christian Kuhn commented on patch set 1 V 0 10/22/12, 16:11

    by team member; Looks good to me, approved
  2. Steffen Ritter commented on patch set 1 10/22/12, 16:11

    Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 10/22/12, 16:11

  4. Wouter Wolters commented on patch set 1 10/22/12, 16:11

    Looks good to me, but someone else must approve
  5. Nicole Hummel commented on patch set 1 10/22/12, 16:11

    Looks good to me, but someone else must approve
  6. Christian Kuhn merged patch set 1 10/22/12, 16:11