Review main Merged

1592[BUGFIX] TCEforms Suggest doesn't search static tables as user

Thomas Maroschik CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

As a backend user, when using a suggest form next to a select
or group field containing entries from a static table I won't
get any results from this table. The pid 0 is not accessible
for regular users, and thus checks against
t3lib_BEfunc::readPageAccess are unneccessary.

Added a condition in t3lib_TCEforms_Suggest_DefaultReceiver::
checkRecordAccess() that checks for an is_static declaration in
TCA ctrl section of the affected table.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Björn Pedersen +1
    • Stefan Neufeind +1
    • Thomas Maroschik +1
  • Verified V +2
    • Andreas Wolf +2
    • Thomas Maroschik +1

Files 1

Review log 15

  1. Björn Pedersen commented on patch set 1 06/16/11, 12:35

    (1 inline comment)

    class.t3lib_tceforms_suggest_defaultreceiver.php:338

    CGL: Use a space after if

    class.t3lib_tceforms_suggest_defaultreceiver.php:338

    CGL: Please use "else if"
  2. Björn Pedersen commented on patch set 1 06/16/11, 12:35

    Looks reasonable.
  3. Andreas Wolf commented on patch set 2 3 comments 06/16/11, 12:35

    Looks good to me, approved I didn't test it, but the code looks good, so go ahead!
  4. Andreas Wolf uploaded patch set 3 06/16/11, 12:35

  5. Björn Pedersen commented on patch set 3 06/16/11, 12:35

    Looks good to me, but someone else must approve
  6. Björn Pedersen commented on patch set 3 06/16/11, 12:35

    (1 inline comment)
  7. Stefan Neufeind commented on patch set 2 06/16/11, 12:35

    Looks good to me, but someone else must approve looks okay at first sight

    class.t3lib_tceforms_suggest_defaultreceiver.php:338 Reply

  8. Stefan Neufeind commented on patch set 3 1 comment 06/16/11, 12:35

    Looks good to me, but someone else must approve
  9. Thomas Maroschik uploaded patch set 2 06/16/11, 12:35

  10. Thomas Maroschik commented on patch set 3 06/16/11, 12:35

    Verified; Looks good to me, but someone else must approve Thank you for the elseif cgl issue clarification. The current version is nice.
  11. Mr. Jenkins commented on patch set 1 06/16/11, 12:35

  12. Mr. Jenkins commented on patch set 2 06/16/11, 12:35

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/538/ : FAILURE
  13. Mr. Jenkins commented on patch set 3 06/16/11, 12:35

  14. Andreas Wolf commented on patch set 3 V 0 06/16/11, 12:35

    by team member; Looks good to me, approved Pushing after two verifications. This change is pretty straightforward, so I don't think we will need another code review.
  15. Andreas Wolf merged patch set 3 06/16/11, 12:35