1592[BUGFIX] TCEforms Suggest doesn't search static tables as user
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Björn Pedersen +1
- Stefan Neufeind +1
- Thomas Maroschik +1
-
Verified V +2
- Andreas Wolf +2
- Thomas Maroschik +1
Files 1
Review log 15
-
Björn Pedersen commented on patch set 1 06/16/11, 12:35
(1 inline comment)class.t3lib_tceforms_suggest_defaultreceiver.php:338CGL: Use a space after ifclass.t3lib_tceforms_suggest_defaultreceiver.php:338CGL: Please use "else if" -
Björn Pedersen commented on patch set 1 06/16/11, 12:35
Looks reasonable. -
Andreas Wolf commented on patch set 2 3 comments 06/16/11, 12:35
Looks good to me, approved I didn't test it, but the code looks good, so go ahead! -
Andreas Wolf uploaded patch set 3 06/16/11, 12:35
-
Björn Pedersen commented on patch set 3 06/16/11, 12:35
Looks good to me, but someone else must approve -
Björn Pedersen commented on patch set 3 06/16/11, 12:35
(1 inline comment) -
Stefan Neufeind commented on patch set 2 06/16/11, 12:35
Looks good to me, but someone else must approve looks okay at first sightclass.t3lib_tceforms_suggest_defaultreceiver.php:338ReplyCGL says elseif: http://wiki.typo3.org/TYPO3_Coding_Guidelines_-_Notes#IF.2FELSE.2FELSEIF also mentioned here: http://lists.typo3.org/pipermail/typo3-project-v4/2011-April/002206.html -
Stefan Neufeind commented on patch set 3 1 comment 06/16/11, 12:35
Looks good to me, but someone else must approve -
Thomas Maroschik uploaded patch set 2 06/16/11, 12:35
-
Thomas Maroschik commented on patch set 3 06/16/11, 12:35
Verified; Looks good to me, but someone else must approve Thank you for the elseif cgl issue clarification. The current version is nice. -
Mr. Jenkins commented on patch set 1 06/16/11, 12:35
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/275/ -
Mr. Jenkins commented on patch set 2 06/16/11, 12:35
Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/538/ : FAILURE -
Mr. Jenkins commented on patch set 3 06/16/11, 12:35
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/633/ : SUCCESS -
Andreas Wolf commented on patch set 3 V 0 06/16/11, 12:35
by team member; Looks good to me, approved Pushing after two verifications. This change is pretty straightforward, so I don't think we will need another code review. -
Andreas Wolf merged patch set 3 06/16/11, 12:35