Review TYPO3_4-7 Merged

15977[TASK] Fix generation of ext_emconf.php

Wouter Wolters CR +2 V +2 Easy +9 −9 updated 06/03/13, 20:49

Commit message

Fix generation of ext_emconf.php so that it will return valid
commented code. This is already done for 6.0

Review

  • Code review CR +2
    • Georg Ringer +2
    • Claus Due +1
    • Helmut Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 4

  1. Helmut Hummel commented on patch set 1 10/27/12, 17:13

    Verified; Looks good to me, but someone else must approve
  2. Georg Ringer commented on patch set 1 V 0 10/27/12, 17:13

    by team member; Looks good to me, approved
  3. Claus Due commented on patch set 1 10/27/12, 17:13

    Looks good to me, but someone else must approve Looks perfect :)
  4. Georg Ringer merged patch set 1 10/27/12, 17:13